Bug 199973 – Add accessibilityInsertText for text insertion in edit fields.

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Andres Gonzalez]

Add accessibilityInsertText for text insertion in edit fields.

[Andres Gonzalez]

Created attachment 374529 [details]
Patch

[chris fleizach]

Comment on attachment 374529 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=374529&action=review

> Source/WebCore/accessibility/AccessibilityObject.cpp:2289
> +    if (element.shouldUseInputMethod()) {

we should do early return styleher

if (!element.shouldUseInputMethod())
    return false;

> Source/WebCore/accessibility/AccessibilityObject.h:717
> +    bool insertText(const String& text);

no need to name parameter here

> LayoutTests/accessibility/insert-newline.html:16
> +        content.focus();

is this the same exact test on iOS? if so we can probably share it  in accessibility folder and skip on other platforms

[Andres Gonzalez]

Created attachment 374534 [details]
Patch

[Andres Gonzalez]

All comments addressed. Thanks.

[chris fleizach]

Comment on attachment 374534 [details]
Patch

We probably need to skip this on gtk and friends

[EWS Watchlist]

Comment on attachment 374534 [details]
Patch

Attachment 374534 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/12777379

New failing tests:
accessibility/insert-newline.html

[EWS Watchlist]

Created attachment 374537 [details]
Archive of layout-test-results from ews102 for mac-highsierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-highsierra  Platform: Mac OS X 10.13.6

[EWS Watchlist]

Comment on attachment 374534 [details]
Patch

Attachment 374534 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/12777526

New failing tests:
accessibility/insert-newline.html

[EWS Watchlist]

Created attachment 374538 [details]
Archive of layout-test-results from ews117 for mac-highsierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117  Port: mac-highsierra  Platform: Mac OS X 10.13.6

[EWS Watchlist]

Comment on attachment 374534 [details]
Patch

Attachment 374534 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/12777561

New failing tests:
accessibility/insert-newline.html

[EWS Watchlist]

Created attachment 374540 [details]
Archive of layout-test-results from ews210 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews210  Port: win-future  Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit

[Andres Gonzalez]

Created attachment 374556 [details]
Patch

[Andres Gonzalez]

<rdar://problem/52146108> When composing a reply to an email with a braille display's keyboard', the cursor will often jump around

[Andres Gonzalez]

Created attachment 374558 [details]
Patch

[EWS Watchlist]

Comment on attachment 374558 [details]
Patch

Attachment 374558 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/12780641

New failing tests:
accessibility/insert-newline.html

[EWS Watchlist]

Created attachment 374561 [details]
Archive of layout-test-results from ews210 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews210  Port: win-future  Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit

[Andres Gonzalez]

Created attachment 374562 [details]
Patch

[EWS]

Comment on attachment 374562 [details]
Patch

Rejecting attachment 374562 [details] from review queue.

[e-mail] does not have reviewer permissions according to https://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json.

- If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your reviewer rights.

[WebKit Commit Bot]

Comment on attachment 374562 [details]
Patch

Clearing flags on attachment: 374562

Committed r247671: <https://trac.webkit.org/changeset/247671>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Andres Gonzalez]

Reopening to attach new patch.

[Andres Gonzalez]

Created attachment 374570 [details]
Patch

[Andres Gonzalez]

Created attachment 374578 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 374578 [details]
Patch

Clearing flags on attachment: 374578

Committed r247677: <https://trac.webkit.org/changeset/247677>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.