Bug 199971 - REGRESSION(rUnknown): YouTube playback pauses when switching to a new tab
Summary: REGRESSION(rUnknown): YouTube playback pauses when switching to a new tab
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-07-19 15:59 PDT by Jer Noble
Modified: 2019-07-22 12:38 PDT (History)
3 users (show)

See Also:


Attachments
Patch (9.90 KB, patch)
2019-07-19 16:04 PDT, Jer Noble
no flags Details | Formatted Diff | Diff
Patch (9.82 KB, patch)
2019-07-19 16:20 PDT, Jer Noble
no flags Details | Formatted Diff | Diff
Patch (9.85 KB, patch)
2019-07-22 11:17 PDT, Jer Noble
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2019-07-19 15:59:17 PDT
REGRESSION(rUnknown): YouTube playback pauses when switching to a new tab
Comment 1 Jer Noble 2019-07-19 16:00:27 PDT
<rdar://problem/51951218>
Comment 2 Jer Noble 2019-07-19 16:04:37 PDT
Created attachment 374516 [details]
Patch
Comment 3 Alex Christensen 2019-07-19 16:11:31 PDT
Comment on attachment 374516 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=374516&action=review

> Tools/TestWebKitAPI/Tests/WebKitCocoa/NoPauseWhenSwitchingTabs.mm:28
> +#if PLATFORM(IOS_FAMILY)

If this works on Mac, let's increase our coverage.

> Tools/TestWebKitAPI/Tests/WebKitCocoa/NoPauseWhenSwitchingTabs.mm:44
> +    RetainPtr<WKWebViewConfiguration> configuration = adoptNS([[WKWebViewConfiguration alloc] init]);

auto

> Tools/TestWebKitAPI/Tests/WebKitCocoa/NoPauseWhenSwitchingTabs.mm:50
> +    RetainPtr<TestWKWebView> webView = adoptNS([[TestWKWebView alloc] initWithFrame:NSMakeRect(0, 0, 300, 300) configuration:configuration.get() addToWindow:YES]);

auto
Comment 4 Jer Noble 2019-07-19 16:20:44 PDT
Created attachment 374520 [details]
Patch
Comment 5 Jer Noble 2019-07-22 11:17:08 PDT
Created attachment 374608 [details]
Patch
Comment 6 WebKit Commit Bot 2019-07-22 12:38:11 PDT
Comment on attachment 374608 [details]
Patch

Clearing flags on attachment: 374608

Committed r247695: <https://trac.webkit.org/changeset/247695>
Comment 7 WebKit Commit Bot 2019-07-22 12:38:13 PDT
All reviewed patches have been landed.  Closing bug.