JSScript.mm:97 #if USE(APPLE_INTERNAL_SDK) if (rootless_check_datavault_flag(FileSystem::fileSystemRepresentation(directory).data(), nullptr)) { createError([NSString stringWithFormat:@"Cache directory `%@` is not a data vault", static_cast<NSString *>(directory)], error); return false; } #endif testapi.mm:2408 testInvalidCacheURL([NSURL URLWithString:@""], @"Cache path `` is not a local file"); testInvalidCacheURL([NSURL URLWithString:@"file:///"], @"Cache path `/` already exists and is not a file"); testInvalidCacheURL([NSURL URLWithString:@"file:///a/b/c/d/e"], @"Cache directory `/a/b/c/d` is not a directory or does not exist"); testInvalidCacheURL([NSURL URLWithString:@"file:///private/tmp/file.cache"], @"Cache directory `/private/tmp` is not a data vault"); ^ this test run without checking if USE(APPLE_INTERNAL_SDK), we don't check this for non internal build (see JSScript.mm:97), therefore no error message will be created, this test will be failed.
Created attachment 374478 [details] Patch
LGTM too.
Comment on attachment 374478 [details] Patch Clearing flags on attachment: 374478 Committed r247690: <https://trac.webkit.org/changeset/247690>
All reviewed patches have been landed. Closing bug.
<rdar://problem/53406975>