Bug 199948 - Make sure to unref captured lambda variables given to _strictTrustEvaluate in the main thread
Summary: Make sure to unref captured lambda variables given to _strictTrustEvaluate in...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
: 199919 (view as bug list)
Depends on:
Blocks:
 
Reported: 2019-07-19 09:59 PDT by youenn fablet
Modified: 2019-07-22 11:52 PDT (History)
4 users (show)

See Also:


Attachments
Patch (3.62 KB, patch)
2019-07-19 10:03 PDT, youenn fablet
no flags Details | Formatted Diff | Diff
Patch (3.46 KB, patch)
2019-07-19 18:24 PDT, youenn fablet
no flags Details | Formatted Diff | Diff
Patch for landing (4.67 KB, patch)
2019-07-22 11:02 PDT, youenn fablet
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2019-07-19 09:59:57 PDT
Make sure to unref captured lambda variables given to _strictTrustEvaluate in the main thread
Comment 1 youenn fablet 2019-07-19 10:03:49 PDT
Created attachment 374472 [details]
Patch
Comment 2 youenn fablet 2019-07-19 10:50:24 PDT
*** Bug 199919 has been marked as a duplicate of this bug. ***
Comment 3 youenn fablet 2019-07-19 18:24:39 PDT
Created attachment 374533 [details]
Patch
Comment 4 Alex Christensen 2019-07-22 10:33:43 PDT
Comment on attachment 374533 [details]
Patch

Sure.  I think it would be a little more consistent with the rest of the code to check the weak pointer in the lambda, then pass a NetworkSessionCocoa& to processServerTrustEvaluation.
Comment 5 youenn fablet 2019-07-22 11:02:18 PDT
Created attachment 374606 [details]
Patch for landing
Comment 6 youenn fablet 2019-07-22 11:04:31 PDT
(In reply to Alex Christensen from comment #4)
> Comment on attachment 374533 [details]
> Patch
> 
> Sure.  I think it would be a little more consistent with the rest of the
> code to check the weak pointer in the lambda, then pass a
> NetworkSessionCocoa& to processServerTrustEvaluation.

Done.
Comment 7 WebKit Commit Bot 2019-07-22 11:51:37 PDT
Comment on attachment 374606 [details]
Patch for landing

Clearing flags on attachment: 374606

Committed r247693: <https://trac.webkit.org/changeset/247693>
Comment 8 WebKit Commit Bot 2019-07-22 11:51:38 PDT
All reviewed patches have been landed.  Closing bug.
Comment 9 Radar WebKit Bug Importer 2019-07-22 11:52:20 PDT
<rdar://problem/53408892>