Since bug 199855 the GTK and WPE testrunner drivers share more code with the base driver. The scripts run-gtk-tests / run-wpe-tests, run-webdriver-tests and run-web-platform-tests need to setup the testrunner driver environment (to maybe start Xvfb or setup needed environment variables). But those scripts don't need the WebTestRunner server process running. Previous to bug 199855 this scripts where setting only the environment variables that don't depend on the Driver tempdir (because this one is created when the driver is started), but starting the driver also executes the server process. I think its desirable to refactor the code to allow creating the driver tempdir and setup the environment completely without needing to start the server process.
Created attachment 374468 [details] Patch
Comment on attachment 374468 [details] Patch Clearing flags on attachment: 374468 Committed r247663: <https://trac.webkit.org/changeset/247663>
All reviewed patches have been landed. Closing bug.
<rdar://problem/53332564>
On further thinking, it seems to me that is also worth also adding an unit test for this.
Created attachment 374597 [details] Patch
Comment on attachment 374597 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=374597&action=review > Tools/Scripts/webkitpy/port/driver_unittest.py:396 > + self.assertNotEqual(environ_driver[var], None) > + > + > def test_create_temporal_home_dir(self): All the other surrounding functions have only one line between them (though I thought two was supposed to be standard for python).
Committed r247682: <https://trac.webkit.org/changeset/247682>