Add a menu item to toggle between showing and hiding link previews
<rdar://problem/53032288>
Created attachment 374460 [details] Patch
Created attachment 374465 [details] Patch
Created attachment 374466 [details] Patch
Comment on attachment 374466 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=374466&action=review > Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:7674 > + if (!originalMenu) Is there ever a case when a menu would no items would be represented by a nil menu? I just want to make sure that if a client removes ALL of the menu items, we still provide this one.
Comment on attachment 374466 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=374466&action=review >> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:7674 >> + if (!originalMenu) > > Is there ever a case when a menu would no items would be represented by a nil menu? I just want to make sure that if a client removes ALL of the menu items, we still provide this one. Good point! Yes, if they remove all the items (which they technically shouldn't do) we have to provide this one. I used to have code where we'd provide all the default actions if they removed everything. I'll make sure that still happens, since that's what HI wanted.
Committed r247652: <https://trac.webkit.org/changeset/247652>