Bug 199934 - [GStreamer] Flush get_range calls during PAUSED->READY in WebKitWebSource
Summary: [GStreamer] Flush get_range calls during PAUSED->READY in WebKitWebSource
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Charlie Turner
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-07-18 23:18 PDT by Charlie Turner
Modified: 2019-07-19 04:44 PDT (History)
3 users (show)

See Also:

Attachments
Patch (1.89 KB, patch)
2019-07-18 23:20 PDT, Charlie Turner 		no flags Details | Formatted Diff | Diff
Patch for landing (1.78 KB, patch)
2019-07-19 01:38 PDT, Charlie Turner 		no flags Details | Formatted Diff | Diff
Patch for landing (1.79 KB, patch)
2019-07-19 01:39 PDT, Charlie Turner 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Charlie Turner 2019-07-18 23:18:18 PDT 
[GStreamer] Flush get_range calls during PAUSED->READY in WebKitWebSource
Comment 1 Charlie Turner 2019-07-18 23:20:57 PDT 
Created attachment 374444 [details]
Patch
Comment 2 Xabier Rodríguez Calvar 2019-07-19 00:07:04 PDT 
Comment on attachment 374444 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=374444&action=review

> Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:780
> +        {

This should go to the line above.

> Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:785
> +        locker.unlockEarly();

This shouldn't be needed.
Comment 3 Charlie Turner 2019-07-19 01:38:55 PDT 
Created attachment 374449 [details]
Patch for landing
Comment 4 Charlie Turner 2019-07-19 01:39:30 PDT 
Created attachment 374450 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2019-07-19 04:43:41 PDT 
Comment on attachment 374450 [details]
Patch for landing

Clearing flags on attachment: 374450

Committed r247643: <https://trac.webkit.org/changeset/247643>
Comment 6 WebKit Commit Bot 2019-07-19 04:43:42 PDT 
All reviewed patches have been landed.  Closing bug.