Bug 199933 - slides.google.com: opening speaker notes while presenting causes a fatal error in the web app on iPad
Summary: slides.google.com: opening speaker notes while presenting causes a fatal erro...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-07-18 23:08 PDT by Maciej Stachowiak
Modified: 2019-07-26 13:34 PDT (History)
13 users (show)

See Also:


Attachments
Patch (4.39 KB, patch)
2019-07-26 11:18 PDT, youenn fablet
no flags Details | Formatted Diff | Diff
Patch (4.39 KB, patch)
2019-07-26 11:20 PDT, youenn fablet
no flags Details | Formatted Diff | Diff
Patch (4.42 KB, patch)
2019-07-26 11:34 PDT, youenn fablet
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Maciej Stachowiak 2019-07-18 23:08:42 PDT
Opening speaker notes while presenting causes a fatal error in the web app on iPad.

Steps to reproduce:

1) Go to https://slides.google.com (log in if necessary)
2) Open a presentation or make a new one from a template
3) Tap the Present button in the upper right next to Share
4) Tap the Notes button on the hover bar at the lower left to open speaker notes

Expected result:
Speaker notes open

Actual result:
A new tab opens with the URL about:invalid#zClosureZ. The original tab stops presenting and shows an alert with the message "This error has been reported to Google and we'll look into it as soon as possible. Please reload this page to continue.
Comment 1 Wenson Hsieh 2019-07-18 23:22:26 PDT
<rdar://problem/53034345>
Comment 2 youenn fablet 2019-07-26 10:39:21 PDT
We could allow about:invalid#zClosureZ to be considered as same origin as the opener (like about:blank).
Or we could simply consider that opening about:invalid#zClosureZ is opening about:blank.
Comment 3 youenn fablet 2019-07-26 11:18:42 PDT
Created attachment 374975 [details]
Patch
Comment 4 youenn fablet 2019-07-26 11:20:49 PDT
Created attachment 374976 [details]
Patch
Comment 5 youenn fablet 2019-07-26 11:34:28 PDT
Created attachment 374977 [details]
Patch
Comment 6 Darin Adler 2019-07-26 12:48:31 PDT
Comment on attachment 374977 [details]
Patch

Maybe too risky for the short term, but should we instead just always unconditionally treat all "about:" URLs as "about:blank"?
Comment 7 youenn fablet 2019-07-26 13:04:39 PDT
(In reply to Darin Adler from comment #6)
> Comment on attachment 374977 [details]
> Patch
> 
> Maybe too risky for the short term, but should we instead just always
> unconditionally treat all "about:" URLs as "about:blank"?

Yes, I reduced the exposure for now.

I looked a bit at what Chrome, Firefox and Safari are doing, and the interop there is very low.
Chrome and Firefox do, in some cases, process partially about:XX as about:blank.
This might be worth documenting the behaviours and try converging.
Comment 8 WebKit Commit Bot 2019-07-26 13:34:34 PDT
Comment on attachment 374977 [details]
Patch

Clearing flags on attachment: 374977

Committed r247873: <https://trac.webkit.org/changeset/247873>
Comment 9 WebKit Commit Bot 2019-07-26 13:34:36 PDT
All reviewed patches have been landed.  Closing bug.