Bug 199933 – slides.google.com: opening speaker notes while presenting causes a fatal error in the web app on iPad

• Status: RESOLVED
• Resolution: FIXED
• Component: HTML Editing

[Maciej Stachowiak]

Opening speaker notes while presenting causes a fatal error in the web app on iPad.

Steps to reproduce:

1) Go to https://slides.google.com (log in if necessary)
2) Open a presentation or make a new one from a template
3) Tap the Present button in the upper right next to Share
4) Tap the Notes button on the hover bar at the lower left to open speaker notes

Expected result:
Speaker notes open

Actual result:
A new tab opens with the URL about:invalid#zClosureZ. The original tab stops presenting and shows an alert with the message "This error has been reported to Google and we'll look into it as soon as possible. Please reload this page to continue.

[Wenson Hsieh]

<rdar://problem/53034345>

[youenn fablet]

We could allow about:invalid#zClosureZ to be considered as same origin as the opener (like about:blank).
Or we could simply consider that opening about:invalid#zClosureZ is opening about:blank.

[youenn fablet]

Created attachment 374975 [details]
Patch

[youenn fablet]

Created attachment 374976 [details]
Patch

[youenn fablet]

Created attachment 374977 [details]
Patch

[Darin Adler]

Comment on attachment 374977 [details]
Patch

Maybe too risky for the short term, but should we instead just always unconditionally treat all "about:" URLs as "about:blank"?

[youenn fablet]

(In reply to Darin Adler from comment #6)
> Comment on attachment 374977 [details]
> Patch
> 
> Maybe too risky for the short term, but should we instead just always
> unconditionally treat all "about:" URLs as "about:blank"?

Yes, I reduced the exposure for now.

I looked a bit at what Chrome, Firefox and Safari are doing, and the interop there is very low.
Chrome and Firefox do, in some cases, process partially about:XX as about:blank.
This might be worth documenting the behaviours and try converging.

[WebKit Commit Bot]

Comment on attachment 374977 [details]
Patch

Clearing flags on attachment: 374977

Committed r247873: <https://trac.webkit.org/changeset/247873>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.