WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED WONTFIX
199932
[WHLSL] Global struct has too many unused members in it
https://bugs.webkit.org/show_bug.cgi?id=199932
Summary
[WHLSL] Global struct has too many unused members in it
Myles C. Maxfield
Reported
2019-07-18 22:10:06 PDT
There are hundreds of members, almost none of which are used. We should gather items in the global struct per entry point, and only in functions which are reachable from that entry point, rather than gathering them across the whole program.
Attachments
Add attachment
proposed patch, testcase, etc.
Saam Barati
Comment 1
2019-07-20 01:49:14 PDT
(In reply to Myles C. Maxfield from
comment #0
)
> There are hundreds of members, almost none of which are used. > > We should gather items in the global struct per entry point, and only in > functions which are reachable from that entry point, rather than gathering > them across the whole program.
We’d also greatly reduce the number if we marked the various take the address of nodes we generate internally with a special bit that they don’t need to be in the struct. same if we skipped stdlib functions
Myles C. Maxfield
Comment 2
2020-05-05 00:42:36 PDT
WHLSL is no longer relevant.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug