Bug 199927 - [webkitperl] prepare-ChangeLog_unittest/parser_unittests.pl is failing on Windows Perl
Summary: [webkitperl] prepare-ChangeLog_unittest/parser_unittests.pl is failing on Win...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Fujii Hironori
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-07-18 18:59 PDT by Fujii Hironori
Modified: 2019-07-23 18:36 PDT (History)
8 users (show)

See Also:


Attachments
Patch (3.04 KB, patch)
2019-07-18 19:27 PDT, Fujii Hironori
achristensen: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Fujii Hironori 2019-07-18 18:59:39 PDT
[Win][webkitperl] prepare-ChangeLog_unittest/parser_unittests.pl is failing on Windows Perl

convertAbsolutepathToWebKitPath has two problems:
1. path separators don't match
2. LoadAsModule::sourceDir() returns "C:/WebKit-BuildWorker/wincairo-wkl-release-tests/build", not "C:\WebKit-BuildWorker\wincairo-wkl-release-tests\build"

https://build.webkit.org/builders/WinCairo%2064-bit%20WKL%20Release%20%28Tests%29/builds/4550/steps/webkitperl-test/logs/stdio

> Tools/Scripts/webkitperl/prepare-ChangeLog_unittest/generateFunctionLists.pl ....................... ok
> Variable "%attributeCache" is not available at (eval 16) line 2113.
> Variable "$devNull" is not available at (eval 16) line 2119.
> 
> #   Failed test 'Tests C:\WebKit-BuildWorker\wincairo-wkl-release-tests\build\Tools\Scripts\webkitperl\prepare-ChangeLog_unittest\resources\css_unittests_warning.css'
> #   at Tools/Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl line 92.
> # 
> #     Structures begin differing at:
> #          $got->{stderr} = 'mismatched comment found in C:\WebKit-BuildWorker\wincairo-wkl-release-tests\build\Tools\Scripts\webkitperl\prepare-ChangeLog_unittest\resources\css_unittests_warning.css:21
> 
> #     mismatched comment found in C:\WebKit-BuildWorker\wincairo-wkl-release-tests\build\Tools\Scripts\webkitperl\prepare-ChangeLog_unittest\resources\css_unittests_warning.css:25
> 
> #     mismatched comment found in C:\WebKit-BuildWorker\wincairo-wkl-release-tests\build\Tools\Scripts\webkitperl\prepare-ChangeLog_unittest\resources\css_unittests_warning.css:29
> 
> #     mismatched opening brace found in C:\WebKit-BuildWorker\wincairo-wkl-release-tests\build\Tools\Scripts\webkitperl\prepare-ChangeLog_unittest\resources\css_unittests_warning.css:33
> 
> #     mismatched closing brace found in C:\WebKit-BuildWorker\wincairo-wkl-release-tests\build\Tools\Scripts\webkitperl\prepare-ChangeLog_unittest\resources\css_unittests_warning.css:34
> 
> #     mismatched opening brace found in C:\WebKit-BuildWorker\wincairo-wkl-release-tests\build\Tools\Scripts\webkitperl\prepare-ChangeLog_unittest\resources\css_unittests_warning.css:37
> 
> #     mismatched closing brace found in C:\WebKit-BuildWorker\wincairo-wkl-release-tests\build\Tools\Scripts\webkitperl\prepare-ChangeLog_unittest\resources\css_unittests_warning.css:42
> 
> #     '
> #     $expected->{stderr} = 'mismatched comment found in Tools/Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests_warning.css:21
> #     mismatched comment found in Tools/Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests_warning.css:25
> #     mismatched comment found in Tools/Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests_warning.css:29
> #     mismatched opening brace found in Tools/Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests_warning.css:33
> #     mismatched closing brace found in Tools/Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests_warning.css:34
> #     mismatched opening brace found in Tools/Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests_warning.css:37
> #     mismatched closing brace found in Tools/Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests_warning.css:42
> #     '
> # 
> # Looks like you failed 1 test of 8.
> Tools/Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl ............................ 
> Dubious, test returned 1 (wstat 256, 0x100)
> Failed 1/8 subtests
Comment 1 Fujii Hironori 2019-07-18 19:27:55 PDT
Created attachment 374436 [details]
Patch
Comment 2 Fujii Hironori 2019-07-23 18:34:14 PDT
Committed r247763: <https://trac.webkit.org/changeset/247763>
Comment 3 Radar WebKit Bug Importer 2019-07-23 18:36:59 PDT
<rdar://problem/53475805>