Bug 199927 – [webkitperl] prepare-ChangeLog_unittest/parser_unittests.pl is failing on Windows Perl

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Fujii Hironori]

[Win][webkitperl] prepare-ChangeLog_unittest/parser_unittests.pl is failing on Windows Perl

convertAbsolutepathToWebKitPath has two problems:
1. path separators don't match
2. LoadAsModule::sourceDir() returns "C:/WebKit-BuildWorker/wincairo-wkl-release-tests/build", not "C:\WebKit-BuildWorker\wincairo-wkl-release-tests\build"

https://build.webkit.org/builders/WinCairo%2064-bit%20WKL%20Release%20%28Tests%29/builds/4550/steps/webkitperl-test/logs/stdio

> Tools/Scripts/webkitperl/prepare-ChangeLog_unittest/generateFunctionLists.pl ....................... ok
> Variable "%attributeCache" is not available at (eval 16) line 2113.
> Variable "$devNull" is not available at (eval 16) line 2119.
> 
> #   Failed test 'Tests C:\WebKit-BuildWorker\wincairo-wkl-release-tests\build\Tools\Scripts\webkitperl\prepare-ChangeLog_unittest\resources\css_unittests_warning.css'
> #   at Tools/Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl line 92.
> # 
> #     Structures begin differing at:
> #          $got->{stderr} = 'mismatched comment found in C:\WebKit-BuildWorker\wincairo-wkl-release-tests\build\Tools\Scripts\webkitperl\prepare-ChangeLog_unittest\resources\css_unittests_warning.css:21
> 
> #     mismatched comment found in C:\WebKit-BuildWorker\wincairo-wkl-release-tests\build\Tools\Scripts\webkitperl\prepare-ChangeLog_unittest\resources\css_unittests_warning.css:25
> 
> #     mismatched comment found in C:\WebKit-BuildWorker\wincairo-wkl-release-tests\build\Tools\Scripts\webkitperl\prepare-ChangeLog_unittest\resources\css_unittests_warning.css:29
> 
> #     mismatched opening brace found in C:\WebKit-BuildWorker\wincairo-wkl-release-tests\build\Tools\Scripts\webkitperl\prepare-ChangeLog_unittest\resources\css_unittests_warning.css:33
> 
> #     mismatched closing brace found in C:\WebKit-BuildWorker\wincairo-wkl-release-tests\build\Tools\Scripts\webkitperl\prepare-ChangeLog_unittest\resources\css_unittests_warning.css:34
> 
> #     mismatched opening brace found in C:\WebKit-BuildWorker\wincairo-wkl-release-tests\build\Tools\Scripts\webkitperl\prepare-ChangeLog_unittest\resources\css_unittests_warning.css:37
> 
> #     mismatched closing brace found in C:\WebKit-BuildWorker\wincairo-wkl-release-tests\build\Tools\Scripts\webkitperl\prepare-ChangeLog_unittest\resources\css_unittests_warning.css:42
> 
> #     '
> #     $expected->{stderr} = 'mismatched comment found in Tools/Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests_warning.css:21
> #     mismatched comment found in Tools/Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests_warning.css:25
> #     mismatched comment found in Tools/Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests_warning.css:29
> #     mismatched opening brace found in Tools/Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests_warning.css:33
> #     mismatched closing brace found in Tools/Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests_warning.css:34
> #     mismatched opening brace found in Tools/Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests_warning.css:37
> #     mismatched closing brace found in Tools/Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests_warning.css:42
> #     '
> # 
> # Looks like you failed 1 test of 8.
> Tools/Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl ............................ 
> Dubious, test returned 1 (wstat 256, 0x100)
> Failed 1/8 subtests

[Fujii Hironori]

Created attachment 374436 [details]
Patch

[Fujii Hironori]

Committed r247763: <https://trac.webkit.org/changeset/247763>

[Radar WebKit Bug Importer]

<rdar://problem/53475805>