RESOLVED FIXED 199923
Add and test _WKWebsiteDataStoreConfiguration.deviceIdHashSaltsStorageDirectory SPI 
https://bugs.webkit.org/show_bug.cgi?id=199923
Summary Add and test _WKWebsiteDataStoreConfiguration.deviceIdHashSaltsStorageDirecto...
Alex Christensen
Reported 2019-07-18 16:25:37 PDT
Add and test _WKWebsiteDataStoreConfiguration.deviceIdHashSaltsStorageDirectory SPI
Attachments
Patch (7.45 KB, patch)
2019-07-18 16:27 PDT, Alex Christensen 		youennf: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2019-07-18 16:27:05 PDT
Created attachment 374425 [details] Patch
youenn fablet
Comment 2 2019-07-18 16:38:51 PDT
Comment on attachment 374425 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=374425&action=review > Tools/TestWebKitAPI/Tests/WebKit/GetUserMediaNavigation.mm:106 > + NSURL *tempDir = [NSURL fileURLWithPath:[NSTemporaryDirectory() stringByAppendingPathComponent:@"CustomPathsTest"] isDirectory:YES]; Maybe add EXPECT_FALSE([fileManager fileExistsAtPath:[tempDir URLByAppendingPathComponent:@"1"].path]) > Tools/TestWebKitAPI/Tests/WebKit/GetUserMediaNavigation.mm:120 > + webView.UIDelegate = delegate.get(); Shouldn't we load a page like [webView loadTestPageNamed:@"enumerateMediaDevices"]?
Alex Christensen
Comment 3 2019-07-18 16:44:23 PDT
(In reply to youenn fablet from comment #2) > Comment on attachment 374425 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=374425&action=review > > > Tools/TestWebKitAPI/Tests/WebKit/GetUserMediaNavigation.mm:106 > > + NSURL *tempDir = [NSURL fileURLWithPath:[NSTemporaryDirectory() stringByAppendingPathComponent:@"CustomPathsTest"] isDirectory:YES]; > > Maybe add EXPECT_FALSE([fileManager fileExistsAtPath:[tempDir > URLByAppendingPathComponent:@"1"].path]) Will do. > > Tools/TestWebKitAPI/Tests/WebKit/GetUserMediaNavigation.mm:120 > > + webView.UIDelegate = delegate.get(); > > Shouldn't we load a page like [webView > loadTestPageNamed:@"enumerateMediaDevices"]? Strange. I will, but it wasn't necessary to write the "1" directory. We should probably fix that.
Alex Christensen
Comment 4 2019-07-18 16:46:50 PDT
Comment on attachment 374425 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=374425&action=review > Source/WebKit/UIProcess/API/Cocoa/_WKWebsiteDataStoreConfiguration.mm:113 > + [NSException raise:NSInvalidArgumentException format:@"Cannot set networkCacheDirectory on a non-persistent _WKWebsiteDataStoreConfiguration."]; I also fixed this string to say deviceIdHashSaltsStorageDirectory. http://trac.webkit.org/r247625
Note You need to log in before you can comment on or make changes to this bug.