Bug 199905 – REGRESSION: Panning on an Amazon product image scrolls the page on iPadOS

• Status: RESOLVED
• Resolution: FIXED
• Component: UI Events

[Antoine Quint]

REGRESSION: Panning on an Amazon product image scrolls the page on iPadOS

[Antoine Quint]

Created attachment 374380 [details]
Patch

[Antoine Quint]

<rdar://problem/49124529>

[Antoine Quint]

Created attachment 374382 [details]
Patch

[EWS Watchlist]

Comment on attachment 374382 [details]
Patch

Attachment 374382 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/12766255

New failing tests:
storage/indexeddb/dont-wedge.html

[EWS Watchlist]

Created attachment 374388 [details]
Archive of layout-test-results from ews114 for mac-highsierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114  Port: mac-highsierra  Platform: Mac OS X 10.13.6

[Dean Jackson]

Comment on attachment 374382 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=374382&action=review

> Source/WebCore/page/Quirks.cpp:283
> +    if (isAmazon() && is<Element>(target)) {

Do you need to check target is not null?

[Antoine Quint]

Committed r247568: <https://trac.webkit.org/changeset/247568>

[Chris Dumez]

Comment on attachment 374382 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=374382&action=review

>> Source/WebCore/page/Quirks.cpp:283
>> +    if (isAmazon() && is<Element>(target)) {
> 
> Do you need to check target is not null?

No, is<>() does does when you pass it a raw pointer.

> Source/WebCore/page/Quirks.cpp:286
> +        auto* element = downcast<Element>(target);

Could be:
auto& element = downcast<Element>(*target);