Bug 199905 - REGRESSION: Panning on an Amazon product image scrolls the page on iPadOS
Summary: REGRESSION: Panning on an Amazon product image scrolls the page on iPadOS
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: UI Events (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-07-18 06:36 PDT by Antoine Quint
Modified: 2019-07-18 11:58 PDT (History)
6 users (show)

See Also:

Attachments
Patch (4.60 KB, patch)
2019-07-18 06:39 PDT, Antoine Quint 		no flags Details | Formatted Diff | Diff
Patch (4.85 KB, patch)
2019-07-18 06:56 PDT, Antoine Quint 		dino: review+
ews-watchlist: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews114 for mac-highsierra (3.05 MB, application/zip)
2019-07-18 08:47 PDT, EWS Watchlist 		no flags Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2019-07-18 06:36:29 PDT 
REGRESSION: Panning on an Amazon product image scrolls the page on iPadOS
Comment 1 Antoine Quint 2019-07-18 06:39:10 PDT 
Created attachment 374380 [details]
Patch
Comment 2 Antoine Quint 2019-07-18 06:39:15 PDT 
<rdar://problem/49124529>
Comment 3 Antoine Quint 2019-07-18 06:56:04 PDT 
Created attachment 374382 [details]
Patch
Comment 4 EWS Watchlist 2019-07-18 08:47:27 PDT 
Comment on attachment 374382 [details]
Patch

Attachment 374382 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/12766255

New failing tests:
storage/indexeddb/dont-wedge.html
Comment 5 EWS Watchlist 2019-07-18 08:47:29 PDT 
Created attachment 374388 [details]
Archive of layout-test-results from ews114 for mac-highsierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114  Port: mac-highsierra  Platform: Mac OS X 10.13.6
Comment 6 Dean Jackson 2019-07-18 11:55:33 PDT 
Comment on attachment 374382 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=374382&action=review

> Source/WebCore/page/Quirks.cpp:283
> +    if (isAmazon() && is<Element>(target)) {

Do you need to check target is not null?
Comment 7 Antoine Quint 2019-07-18 11:57:45 PDT 
Committed r247568: <https://trac.webkit.org/changeset/247568>
Comment 8 Chris Dumez 2019-07-18 11:58:47 PDT 
Comment on attachment 374382 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=374382&action=review

>> Source/WebCore/page/Quirks.cpp:283
>> +    if (isAmazon() && is<Element>(target)) {
> 
> Do you need to check target is not null?

No, is<>() does does when you pass it a raw pointer.

> Source/WebCore/page/Quirks.cpp:286
> +        auto* element = downcast<Element>(target);

Could be:
auto& element = downcast<Element>(*target);