Bug 199904 – Ensure Quirks::shouldDispatchSimulatedMouseEvents() works for all Google Maps and Amazon domains

• Status: RESOLVED
• Resolution: FIXED
• Component: UI Events

[Antoine Quint]

A comment made on https://bugs.webkit.org/show_bug.cgi?id=198657 indicates that the quirk added to dispatch simulated mouse events to the Street View icon on Google Maps only works on the google.com domain but Google Maps could also be served via a google.co.jp or google.fr domain for which the quirk doesn't work! Likewise, Quirks::shouldDispatchSimulatedMouseEvents() uses amazon.com to check whether we are on an Amazon property, but this is bad since Amazon also uses amazon.fr and other local domains.

[Radar WebKit Bug Importer]

<rdar://problem/53250104>

[Michael Catanzaro]

The solution we use for Google user agent quirks is:

String baseDomain = topPrivatelyControlledDomain(url.host().toString());
if (baseDomain.startsWith("google."))
   // do something

We also have quirks for gstatic.com, googleapis.com, and googleusercontent.com, but none of those are likely relevant to your Maps problem.

[Antoine Quint]

Thanks Michael, this is really helpful! I'll use a similar approach to detect a Google and Amazon property.

[Antoine Quint]

Created attachment 374408 [details]
Patch

[Antoine Quint]

Committed r247621: <https://trac.webkit.org/changeset/247621>