Bug 199889 - Unable to bring up custom media controls on iOS for video.sina.cn
Summary: Unable to bring up custom media controls on iOS for video.sina.cn
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-07-17 16:09 PDT by Antoine Quint
Modified: 2019-07-19 09:46 PDT (History)
6 users (show)

See Also:

Attachments
Patch (9.28 KB, patch)
2019-07-17 16:19 PDT, Antoine Quint 		no flags Details | Formatted Diff | Diff
Patch for landing (1.75 KB, patch)
2019-07-19 07:33 PDT, Antoine Quint 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2019-07-17 16:09:23 PDT 
Unable to bring up custom media controls on iOS for video.sina.cn
Comment 1 Antoine Quint 2019-07-17 16:19:47 PDT 
Created attachment 374347 [details]
Patch
Comment 2 Antoine Quint 2019-07-17 16:22:43 PDT 
<rdar://problem/51883919>
Comment 3 Antoine Quint 2019-07-17 16:57:38 PDT 
Committed r247544: <https://trac.webkit.org/changeset/247544>
Comment 4 Ryan Haddad 2019-07-18 17:55:04 PDT 
The test added with this change is consistently timing out on iOS Simulator bots:
media/modern-media-controls/media-controller/ios/media-controller-allows-click-over-video-with-no-controls.html

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=media%2Fmodern-media-controls%2Fmedia-controller%2Fios%2Fmedia-controller-allows-click-over-video-with-no-controls.html
Comment 5 Antoine Quint 2019-07-19 07:28:25 PDT 
(In reply to Ryan Haddad from comment #4)
> The test added with this change is consistently timing out on iOS Simulator
> bots:
> media/modern-media-controls/media-controller/ios/media-controller-allows-
> click-over-video-with-no-controls.html
> 
> https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.
> html#showAllRuns=true&tests=media%2Fmodern-media-controls%2Fmedia-
> controller%2Fios%2Fmedia-controller-allows-click-over-video-with-no-controls.
> html

That's right, this should be skipped on OpenSource bots. I'll get to it later today.
Comment 6 Antoine Quint 2019-07-19 07:33:32 PDT 
Reopening to attach new patch.
Comment 7 Antoine Quint 2019-07-19 07:33:34 PDT 
Created attachment 374463 [details]
Patch for landing
Comment 8 WebKit Commit Bot 2019-07-19 08:51:45 PDT 
Comment on attachment 374463 [details]
Patch for landing

Clearing flags on attachment: 374463

Committed r247645: <https://trac.webkit.org/changeset/247645>
Comment 9 WebKit Commit Bot 2019-07-19 08:51:47 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 10 Truitt Savell 2019-07-19 09:44:45 PDT 
It looks like the new test media/modern-media-controls/media-controller/ios/media-controller-allows-click-over-video-with-no-controls.html

added in https://trac.webkit.org/changeset/247612/webkit

Is timing out on iOS.

history:
https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=media%2Fmodern-media-controls%2Fmedia-controller%2Fios%2Fmedia-controller-allows-click-over-video-with-no-controls.html
Comment 11 Truitt Savell 2019-07-19 09:46:08 PDT 
Just realized the patch for this just landed and hasn't hit the bots. disregard me, sorry.