Bug 199887 - Provide a NSURL cateogry to tell AppSSO Kerberos URLs
Summary: Provide a NSURL cateogry to tell AppSSO Kerberos URLs
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jiewen Tan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-07-17 15:34 PDT by Jiewen Tan
Modified: 2019-07-17 17:15 PDT (History)
5 users (show)

See Also:


Attachments
Patch (2.42 KB, patch)
2019-07-17 15:42 PDT, Jiewen Tan
no flags Details | Formatted Diff | Diff
Patch (2.43 KB, patch)
2019-07-17 16:52 PDT, Jiewen Tan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jiewen Tan 2019-07-17 15:34:01 PDT
Provide a NSURL cateogry to tell AppSSO Kerberos URLs.
Comment 1 Jiewen Tan 2019-07-17 15:34:31 PDT
<rdar://problem/52323161>
Comment 2 Jiewen Tan 2019-07-17 15:42:49 PDT
Created attachment 374344 [details]
Patch
Comment 3 Brent Fulgham 2019-07-17 15:54:32 PDT
Comment on attachment 374344 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=374344&action=review

> Source/WebKit/UIProcess/Cocoa/SOAuthorization/SOAuthorizationNSURLExtras.mm:42
> ++ (BOOL)_web_canPerformKerberosAuthorizationWithURL:(NSURL *)url

Should this be "_web_willPerformKerberosAuthorizationWithURL"? Or do we now know -- is it anything subject to SOAuthorization that should be handled this way?

That might indicate that this should be "_web_canPerformSOAuthorizatoin" or "_web_willAttemptSOAuthorization" or something.
Comment 4 Jiewen Tan 2019-07-17 16:40:43 PDT
Comment on attachment 374344 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=374344&action=review

>> Source/WebKit/UIProcess/Cocoa/SOAuthorization/SOAuthorizationNSURLExtras.mm:42
>> ++ (BOOL)_web_canPerformKerberosAuthorizationWithURL:(NSURL *)url
> 
> Should this be "_web_willPerformKerberosAuthorizationWithURL"? Or do we now know -- is it anything subject to SOAuthorization that should be handled this way?
> 
> That might indicate that this should be "_web_canPerformSOAuthorizatoin" or "_web_willAttemptSOAuthorization" or something.

Thanks, Brent. I made it + (BOOL)_web_willPerformSOKerberosAuthorizationWithURL:(NSURL *)url.
Comment 5 Jiewen Tan 2019-07-17 16:52:49 PDT
Created attachment 374351 [details]
Patch
Comment 6 Brent Fulgham 2019-07-17 16:53:28 PDT
Comment on attachment 374351 [details]
Patch

Thanks for changing the naming.
Comment 7 Jiewen Tan 2019-07-17 16:54:39 PDT
(In reply to Brent Fulgham from comment #6)
> Comment on attachment 374351 [details]
> Patch
> 
> Thanks for changing the naming.

Thanks for r+ it.
Comment 8 WebKit Commit Bot 2019-07-17 17:15:07 PDT
Comment on attachment 374351 [details]
Patch

Clearing flags on attachment: 374351

Committed r247547: <https://trac.webkit.org/changeset/247547>
Comment 9 WebKit Commit Bot 2019-07-17 17:15:08 PDT
All reviewed patches have been landed.  Closing bug.