Bug 199870 – check-webkit-style: Add limited Python3 support

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Jonathan Bedard]

Pylint isn't practical (since check-webkit-style is Python 2, any Python 3 syntax will fail), but pycodestyle (the replacement for pep8) is.

[Jonathan Bedard]

I also think that our current version of pep8 doesn't support Python 3.

[Jonathan Bedard]

Created attachment 374309 [details]
Patch

[Dean Johnson]

Comment on attachment 374309 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=374309&action=review

Looks mostly good to me, but I am curious about the categories missing for pycodestyle/W191 and pycodestyle/W291.

> Tools/Scripts/webkitpy/style/checker.py:428
> +    categories = categories.union(["pep8/W191", "pep8/W291", "pep8/E501", "pycodestyle/E501"])

Any reason not to add pycodestyle/W191 and pycodestyle/W291?

> Tools/Scripts/webkitpy/style/checkers/python.py:32
> +from webkitpy.thirdparty.autoinstalled import pycodestyle

Maybe we should put this import into `def check` so it isn't installed for everyone who isn't trying to check python3 code style?

> Tools/Scripts/webkitpy/style/checkers/python.py:142
> +            code = text[:4]

Can you add comments or links to documentation for this?

> Tools/Scripts/webkitpy/style/checkers/python.py:143
> +            message = text[5:]

Ditto.

> Tools/Scripts/webkitpy/style/checkers/python.py:145
> +            self._handle_style_error(line_number, category, 5, message)

Ditto (on '5').

[Jonathan Bedard]

Comment on attachment 374309 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=374309&action=review

>> Tools/Scripts/webkitpy/style/checker.py:428
>> +    categories = categories.union(["pep8/W191", "pep8/W291", "pep8/E501", "pycodestyle/E501"])
> 
> Any reason not to add pycodestyle/W191 and pycodestyle/W291?

Because that's supporting Tools/WebGPUAPIStructure, which it looks like might have tabs in it.

In short, we don't need it, and I'm trying not to inherit any more of webkitpy's technical debt than I have to.

[Jonathan Bedard]

Created attachment 374318 [details]
Patch

[Aakash Jain]

rs=me

[Jonathan Bedard]

Created attachment 374323 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 374323 [details]
Patch

Clearing flags on attachment: 374323

Committed r247538: <https://trac.webkit.org/changeset/247538>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/53222060>