Hang in WebCore::AccessibilityRenderObject::visiblePositionRangeForLine.
Created attachment 374270 [details] Patch
<rdar://problem/53121017>
Comment on attachment 374270 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=374270&action=review > Source/WebCore/accessibility/AccessibilityRenderObject.cpp:-1970 > - if (!lineCount || !m_renderer) NSNotFound is an apple thing, so this check needs to be in the Mac wrapper. also probably sufficient to check if it’s equals to nsnotfound. I think it’s already uint max so it won’t matter checking higher > Source/WebCore/accessibility/AccessibilityRenderObject.cpp:1983 > + || visiblePos.equals(savedVisiblePos)) surprised the == operator doesn’t call .equals directly
Created attachment 374279 [details] Patch
(In reply to chris fleizach from comment #3) > Comment on attachment 374270 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=374270&action=review > > > Source/WebCore/accessibility/AccessibilityRenderObject.cpp:-1970 > > - if (!lineCount || !m_renderer) > > NSNotFound is an apple thing, so this check needs to be in the Mac wrapper. > also probably sufficient to check if it’s equals to nsnotfound. I think it’s > already uint max so it won’t matter checking higher > Done. > > Source/WebCore/accessibility/AccessibilityRenderObject.cpp:1983 > > + || visiblePos.equals(savedVisiblePos)) > > surprised the == operator doesn’t call .equals directly The equals method has a FIXME comment in the header file: // FIXME: Combine this function with operator== and looking at the implementation, it does a lot more than operator==.
Comment on attachment 374279 [details] Patch Clearing flags on attachment: 374279 Committed r247519: <https://trac.webkit.org/changeset/247519>
All reviewed patches have been landed. Closing bug.