Bug 199844 – Make ANGLE work inside WebKit2's sandbox

• Status: RESOLVED
• Resolution: FIXED
• Component: WebGL

[Kenneth Russell]

WebKit's current ANGLE snapshot doesn't work inside WebKit2's sandbox because it makes a deprecated API call, CGDisplayIOServicePort, which is only used to determine the "active" GPU on dual-GPU MacBook Pros. It doesn't otherwise impact ANGLE's internal logic, nor consumers like WebCore. Top-of-tree ANGLE has removed this API call in http://crbug.com/angleproject/3383 . Cherry-picking that commit makes WebKit's ANGLE backend for WebGL work in WebKit2.

[Kenneth Russell]

Created attachment 374264 [details]
Patch

[EWS Watchlist]

Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE

[Kenneth Russell]

The attached patch is just an application of https://chromium-review.googlesource.com/1584360 with one merge conflict resolved, and also a tiny fix to WebGLLayer.mm fixing a build failure with USE_ANGLE=1 that I introduced at the last minute in my most recent patch (sorry!). It makes WebKit's ANGLE / WebGL backend run in WebKit2 mode in the minibrowser.

[EWS Watchlist]

Comment on attachment 374264 [details]
Patch

Attachment 374264 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/12754839

New failing tests:
http/tests/css/filters-on-iframes-transform.html

[EWS Watchlist]

Created attachment 374269 [details]
Archive of layout-test-results from ews212 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews212  Port: win-future  Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit

[Alexey Proskuryakov]

Could you please elaborate on what the user visible issue is? If we didn’t notice a full “doesn’t work”, that would be sad and surprising.

[Radar WebKit Bug Importer]

<rdar://problem/53186410>

[Alex Christensen]

Comment on attachment 374264 [details]
Patch

Kenneth is working on a WebGL implementation that not only uses ANGLE for shader translation, but also for rendering instead of using OpenGL/OpenGLES directly like we do now.  This affects that WebGL implementation.  ANGLE as a text-in-text-out translator does not need this change, so shipping WebGL is not broken and is unaffected by this patch.  r=me

[WebKit Commit Bot]

Comment on attachment 374264 [details]
Patch

Clearing flags on attachment: 374264

Committed r247521: <https://trac.webkit.org/changeset/247521>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.