Bug 199840 - REGRESSION: fast/events/watchos/double-tap-to-zoom* tests crashing in com.apple.WebKit: -[WKContentView(WKInteraction) _singleTapDidReset:]
Summary: REGRESSION: fast/events/watchos/double-tap-to-zoom* tests crashing in com.app...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: UI Events (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
: 199911 (view as bug list)
Depends on:
Blocks:
 
Reported: 2019-07-16 16:03 PDT by Antoine Quint
Modified: 2019-07-18 11:00 PDT (History)
5 users (show)

See Also:

Attachments
Patch (19.42 KB, patch)
2019-07-16 16:07 PDT, Antoine Quint 		no flags Details | Formatted Diff | Diff
Patch for landing (18.64 KB, patch)
2019-07-16 16:24 PDT, Antoine Quint 		no flags Details | Formatted Diff | Diff
Patch for landing (16.97 KB, patch)
2019-07-16 16:33 PDT, Antoine Quint 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2019-07-16 16:03:42 PDT 
REGRESSION: fast/events/watchos/double-tap-to-zoom* tests crashing in com.apple.WebKit: -[WKContentView(WKInteraction) _singleTapDidReset:]
Comment 1 Antoine Quint 2019-07-16 16:07:22 PDT 
Created attachment 374254 [details]
Patch
Comment 2 Antoine Quint 2019-07-16 16:07:27 PDT 
<rdar://problem/52856531>
Comment 3 Wenson Hsieh 2019-07-16 16:13:33 PDT 
Comment on attachment 374254 [details]
Patch

Looks find to me. Is there a reason to prefer this over making _lastActiveTouchIdentifier an ivar of type RetainPtr<NSNumber>, and then exposing a getter that returns _lastActiveTouchIdentifier.get()? I think this is how most of our ObjC properties in WebKit are implemented.
Comment 4 Wenson Hsieh 2019-07-16 16:14:51 PDT 
(In reply to Wenson Hsieh from comment #3)
> Comment on attachment 374254 [details]
> Patch
> 
> Looks find to me. Is…

s/find/fine/
Comment 5 Antoine Quint 2019-07-16 16:24:00 PDT 
Created attachment 374258 [details]
Patch for landing
Comment 6 Antoine Quint 2019-07-16 16:24:49 PDT 
(In reply to Wenson Hsieh from comment #3)
> Comment on attachment 374254 [details]
> Patch
> 
> Looks find to me. Is there a reason to prefer this over making
> _lastActiveTouchIdentifier an ivar of type RetainPtr<NSNumber>, and then
> exposing a getter that returns _lastActiveTouchIdentifier.get()? I think
> this is how most of our ObjC properties in WebKit are implemented.

No reason, I just wasn't aware. Thanks for bringing this up, I think I did what you suggested in the patch for landing. Let me know if it isn't quite right.
Comment 7 Antoine Quint 2019-07-16 16:33:01 PDT 
Created attachment 374259 [details]
Patch for landing
Comment 8 WebKit Commit Bot 2019-07-16 19:46:15 PDT 
Comment on attachment 374259 [details]
Patch for landing

Clearing flags on attachment: 374259

Committed r247502: <https://trac.webkit.org/changeset/247502>
Comment 9 WebKit Commit Bot 2019-07-16 19:46:16 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 10 Wenson Hsieh 2019-07-18 11:00:50 PDT 
*** Bug 199911 has been marked as a duplicate of this bug. ***