Bug 199826 - [GTK] No web view updates after swapping web process if AC mode is forced
Summary: [GTK] No web view updates after swapping web process if AC mode is forced
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2019-07-16 07:23 PDT by Carlos Garcia Campos
Modified: 2019-07-17 01:21 PDT (History)
2 users (show)

See Also:


Attachments
Patch (2.57 KB, patch)
2019-07-16 07:26 PDT, Carlos Garcia Campos
mcatanzaro: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2019-07-16 07:23:11 PDT
This can be easily reproduced with MiniBrowser.

1- Start MB with WEBKIT_FORCE_COMPOSITING_MODE=1
2- Wait until webkitgtk.org loads
3- Load google.com (or any other page that make a cross site navigation)

This is because when AC mode is forced the provisional page creates a drawing area that is always in AC mode. When swapping processes, the current drawing area is destroyed (which exists AC mode) and the provisional one is set. From that point the web process is in AC mode but the UI process isn't. We need to update the compositing mode when swapping processes.
Comment 1 Carlos Garcia Campos 2019-07-16 07:26:58 PDT
Created attachment 374206 [details]
Patch
Comment 2 Carlos Garcia Campos 2019-07-17 01:21:22 PDT
Committed r247506: <https://trac.webkit.org/changeset/247506>