Bug 199818 – IndexedDB: error in starting version change transaction may be neglected

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Sihui Liu]

For version change transaction, IDBServer doesn't wait the result of beginTransaction from the background thread before giving the IDBClient the result of open request.
In this case, we could fail to update version number of IDBDatabaseInfo.

[Sihui Liu]

Created attachment 374175 [details]
Patch

[EWS Watchlist]

Comment on attachment 374175 [details]
Patch

Attachment 374175 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/12746993

New failing tests:
storage/indexeddb/intversion-long-queue-private.html
storage/indexeddb/intversion-long-queue.html

[EWS Watchlist]

Created attachment 374181 [details]
Archive of layout-test-results from ews101 for mac-highsierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-highsierra  Platform: Mac OS X 10.13.6

[EWS Watchlist]

Comment on attachment 374175 [details]
Patch

Attachment 374175 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/12747000

New failing tests:
storage/indexeddb/intversion-long-queue-private.html
storage/indexeddb/intversion-long-queue.html

[EWS Watchlist]

Created attachment 374182 [details]
Archive of layout-test-results from ews104 for mac-highsierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-highsierra-wk2  Platform: Mac OS X 10.13.6

[EWS Watchlist]

Comment on attachment 374175 [details]
Patch

Attachment 374175 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/12746908

New failing tests:
storage/indexeddb/intversion-long-queue-private.html
storage/indexeddb/intversion-long-queue.html

[EWS Watchlist]

Created attachment 374183 [details]
Archive of layout-test-results from ews112 for mac-highsierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-highsierra  Platform: Mac OS X 10.13.6

[EWS Watchlist]

Comment on attachment 374175 [details]
Patch

Attachment 374175 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/12747052

New failing tests:
storage/indexeddb/intversion-long-queue-private.html
storage/indexeddb/intversion-long-queue.html

[EWS Watchlist]

Created attachment 374185 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-wk2  Platform: Mac OS X 10.14.5

[EWS Watchlist]

Comment on attachment 374175 [details]
Patch

Attachment 374175 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/12747715

New failing tests:
storage/indexeddb/intversion-long-queue-private.html
storage/indexeddb/intversion-long-queue.html

[EWS Watchlist]

Created attachment 374191 [details]
Archive of layout-test-results from ews210 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews210  Port: win-future  Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit

[Sihui Liu]

Created attachment 374250 [details]
Patch

[Brady Eidson]

Comment on attachment 374250 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=374250&action=review

> Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp:655
> +    auto operation = WTFMove(m_currentOpenDBRequest);

If you make an `IDBResultData result` after 655...

> Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp:661
> +        operation->connection().didOpenDatabase(result);

This line and 666 are the same, can be moved out if we make a result variable before the if

> Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp:666
> +        operation->connection().didOpenDatabase(result);

This line and 661 are the same, can be moved out if we make a result variable before the if

[Sihui Liu]

<rdar://problem/52925738>

[Sihui Liu]

Created attachment 374304 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 374304 [details]
Patch for landing

Clearing flags on attachment: 374304

Committed r247531: <https://trac.webkit.org/changeset/247531>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Ryan Haddad]

Reverted r247531 for reason:

Caused multiple IndexedDB layout test crashes.

Committed r247624: <https://trac.webkit.org/changeset/247624>

[Sihui Liu]

Created attachment 374431 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 374431 [details]
Patch

Clearing flags on attachment: 374431

Committed r247649: <https://trac.webkit.org/changeset/247649>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.