Currently some error cases are using logging. release logging might be better to debug cases when something wrong happens when data is pushed/pulled in the ring buffer.
<rdar://problem/53128140>
Created attachment 374174 [details] Patch
Comment on attachment 374174 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=374174&action=review > Source/WebCore/ChangeLog:16 > + In that case, we change of logger when changing of MediaStreamTrackPrivate. Nit: s/change of logger when changing of/change the logger when changing the/ > Source/WebCore/platform/audio/mac/AudioSampleDataSource.mm:278 > + ALWAYS_LOG("sample ", timeStamp, " is not completely in range [", startFrame, " .. ", endFrame, "], returning ", framesAvailable, " frames"); > + if (framesAvailable < sampleCount) > + ALWAYS_LOG("not enough data available, returning zeroes"); Nit: should these be ERROR_LOG?
Created attachment 374295 [details] Patch for landing
Comment on attachment 374295 [details] Patch for landing Clearing flags on attachment: 374295 Committed r247522: <https://trac.webkit.org/changeset/247522>
All reviewed patches have been landed. Closing bug.