Bug 199814 - Add release logging to AudioSampleDataSource
Summary: Add release logging to AudioSampleDataSource
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
Keywords: InRadar
Depends on:
Reported: 2019-07-15 16:33 PDT by youenn fablet
Modified: 2019-07-17 11:11 PDT (History)
5 users (show)

See Also:

Patch (16.62 KB, patch)
2019-07-15 17:49 PDT, youenn fablet
no flags Details | Formatted Diff | Diff
Patch for landing (16.64 KB, patch)
2019-07-17 08:42 PDT, youenn fablet
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2019-07-15 16:33:17 PDT
Currently some error cases are using logging. release logging might be better to debug cases when something wrong happens when data is pushed/pulled in the ring buffer.
Comment 1 Radar WebKit Bug Importer 2019-07-15 16:33:41 PDT
Comment 2 youenn fablet 2019-07-15 17:49:23 PDT
Created attachment 374174 [details]
Comment 3 Eric Carlson 2019-07-16 04:49:19 PDT
Comment on attachment 374174 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=374174&action=review

> Source/WebCore/ChangeLog:16
> +        In that case, we change of logger when changing of MediaStreamTrackPrivate.

Nit: s/change of logger when changing of/change the logger when changing the/

> Source/WebCore/platform/audio/mac/AudioSampleDataSource.mm:278
> +            ALWAYS_LOG("sample ", timeStamp, " is not completely in range [", startFrame, " .. ", endFrame, "], returning ", framesAvailable, " frames");
> +            if (framesAvailable < sampleCount)
> +                ALWAYS_LOG("not enough data available, returning zeroes");

Nit: should these be ERROR_LOG?
Comment 4 youenn fablet 2019-07-17 08:42:52 PDT
Created attachment 374295 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2019-07-17 11:11:42 PDT
Comment on attachment 374295 [details]
Patch for landing

Clearing flags on attachment: 374295

Committed r247522: <https://trac.webkit.org/changeset/247522>
Comment 6 WebKit Commit Bot 2019-07-17 11:11:44 PDT
All reviewed patches have been landed.  Closing bug.