Bug 199814 – Add release logging to AudioSampleDataSource

• Status: RESOLVED
• Resolution: FIXED
• Component: WebRTC

[youenn fablet]

Currently some error cases are using logging. release logging might be better to debug cases when something wrong happens when data is pushed/pulled in the ring buffer.

[Radar WebKit Bug Importer]

<rdar://problem/53128140>

[youenn fablet]

Created attachment 374174 [details]
Patch

[Eric Carlson]

Comment on attachment 374174 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=374174&action=review

> Source/WebCore/ChangeLog:16
> +        In that case, we change of logger when changing of MediaStreamTrackPrivate.

Nit: s/change of logger when changing of/change the logger when changing the/

> Source/WebCore/platform/audio/mac/AudioSampleDataSource.mm:278
> +            ALWAYS_LOG("sample ", timeStamp, " is not completely in range [", startFrame, " .. ", endFrame, "], returning ", framesAvailable, " frames");
> +            if (framesAvailable < sampleCount)
> +                ALWAYS_LOG("not enough data available, returning zeroes");

Nit: should these be ERROR_LOG?

[youenn fablet]

Created attachment 374295 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 374295 [details]
Patch for landing

Clearing flags on attachment: 374295

Committed r247522: <https://trac.webkit.org/changeset/247522>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.