Bug 199813 - Hop to main thread for release logging in RealtimeIncomingAudioSource
Summary: Hop to main thread for release logging in RealtimeIncomingAudioSource
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-07-15 16:20 PDT by youenn fablet
Modified: 2019-07-16 08:09 PDT (History)
8 users (show)

See Also:

Attachments
patch (1.77 KB, patch)
2019-07-15 16:28 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
patch (2.04 KB, patch)
2019-07-15 16:46 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2019-07-15 16:20:49 PDT 
Hop to main thread for release logging in RealtimeIncomingAudioSource
Comment 1 Radar WebKit Bug Importer 2019-07-15 16:23:17 PDT 
<rdar://problem/53127693>
Comment 2 youenn fablet 2019-07-15 16:28:19 PDT 
Created attachment 374163 [details]
patch
Comment 3 Chris Dumez 2019-07-15 16:32:02 PDT 
Comment on attachment 374163 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=374163&action=review

> Source/WebCore/ChangeLog:3
> +        Hop to main thread for release logging in RealtimeIncomingAudioSource

Could you please explain why in the change loge? Isn't it safe to call RELEASE_LOG() from another thread?
Comment 4 youenn fablet 2019-07-15 16:46:34 PDT 
Created attachment 374166 [details]
patch
Comment 5 youenn fablet 2019-07-15 16:49:46 PDT 
(In reply to Chris Dumez from comment #3)
> Comment on attachment 374163 [details]
> patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=374163&action=review
> 
> > Source/WebCore/ChangeLog:3
> > +        Hop to main thread for release logging in RealtimeIncomingAudioSource
> 
> Could you please explain why in the change loge? Isn't it safe to call
> RELEASE_LOG() from another thread?

It is not thread safe, see Logger::log in Logger.h.
I updated the change log.
Comment 6 WebKit Commit Bot 2019-07-16 08:09:47 PDT 
Comment on attachment 374166 [details]
patch

Clearing flags on attachment: 374166

Committed r247480: <https://trac.webkit.org/changeset/247480>
Comment 7 WebKit Commit Bot 2019-07-16 08:09:49 PDT 
All reviewed patches have been landed.  Closing bug.