Bug 199812 – Speed up StorageManager::getValues()

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Chris Dumez]

Speed up StorageManager::getValues().

[Chris Dumez]

Created attachment 374161 [details]
Patch

[EWS Watchlist]

Comment on attachment 374161 [details]
Patch

Attachment 374161 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/12746353

New failing tests:
storage/domstorage/localstorage/private-browsing-affects-storage.html

[EWS Watchlist]

Created attachment 374176 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124  Port: ios-simulator-wk2  Platform: Mac OS X 10.14.5

[Chris Dumez]

Created attachment 374177 [details]
Patch

[Chris Dumez]

Created attachment 374187 [details]
Patch

[EWS Watchlist]

Comment on attachment 374187 [details]
Patch

Attachment 374187 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/12748248

New failing tests:
storage/domstorage/localstorage/private-browsing-affects-storage.html

[EWS Watchlist]

Created attachment 374196 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123  Port: ios-simulator-wk2  Platform: Mac OS X 10.14.5

[Chris Dumez]

Created attachment 374212 [details]
Patch

[Radar WebKit Bug Importer]

<rdar://problem/53156441>

[Simon Fraser (smfr)]

Comment on attachment 374212 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=374212&action=review

> Source/WebKit/ChangeLog:11
> +          thread hoping (IPC thread -> Main thread -> StorageManagerThread -> Main Thread)

hopping

[Chris Dumez]

Created attachment 374216 [details]
Patch

[Chris Dumez]

(In reply to Simon Fraser (smfr) from comment #10)
> Comment on attachment 374212 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=374212&action=review
> 
> > Source/WebKit/ChangeLog:11
> > +          thread hoping (IPC thread -> Main thread -> StorageManagerThread -> Main Thread)
> 
> hopping

Darn, I keep making this mistake :D Thanks.

[Geoffrey Garen]

r=me

Can you add a comment about what you used to measure performance? Might be good to check that into PerformanceTests, even if it's manual.

[Chris Dumez]

(In reply to Geoffrey Garen from comment #13)
> r=me
> 
> Can you add a comment about what you used to measure performance? Might be
> good to check that into PerformanceTests, even if it's manual.

I am using the following test page to measure performance:
https://jsbin.com/zivayiviza/edit?html,output

[Chris Dumez]

(In reply to Chris Dumez from comment #14)
> (In reply to Geoffrey Garen from comment #13)
> > r=me
> > 
> > Can you add a comment about what you used to measure performance? Might be
> > good to check that into PerformanceTests, even if it's manual.
> 
> I am using the following test page to measure performance:
> https://jsbin.com/zivayiviza/edit?html,output

Namely, in MobileSafari:
1. Open https://jsbin.com/zivayiviza/edit?html,output
2. Click "Fill Local Storage" button
3. Once the "Done" alert shows, close it and exit MobileSafari
4. Open https://jsbin.com/zivayiviza/edit?html,output again
5. Focus the field

Focusing the field at step 5 is very slow (~500ms) on my iPhone, which is what I am working to improve.

[WebKit Commit Bot]

Comment on attachment 374216 [details]
Patch

Clearing flags on attachment: 374216

Committed r247486: <https://trac.webkit.org/changeset/247486>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.