WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
199802
Add missing webgpu includes
https://bugs.webkit.org/show_bug.cgi?id=199802
Summary
Add missing webgpu includes
Keith Rollin
Reported
2019-07-15 13:31:27 PDT
WHLSLFunctionWriter.cpp fails to compile on tvOS and watchOS due to missing includes. This file likely compiles on other platforms due to the Unified Sources facility that clumps several implementation files together, exposing those implementation files to the others' includes. It fails on tvOS and watchOS due to the different ways these implementation files can get clumped together on different platforms.
Attachments
Patch
(1.78 KB, patch)
2019-07-15 13:34 PDT
,
Keith Rollin
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2019-07-15 13:32:15 PDT
<
rdar://problem/53119120
>
Keith Rollin
Comment 2
2019-07-15 13:34:27 PDT
Created
attachment 374142
[details]
Patch
WebKit Commit Bot
Comment 3
2019-07-15 14:40:34 PDT
Comment on
attachment 374142
[details]
Patch Clearing flags on attachment: 374142 Committed
r247450
: <
https://trac.webkit.org/changeset/247450
>
WebKit Commit Bot
Comment 4
2019-07-15 14:40:36 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug