Bug 199802 - Add missing webgpu includes
Summary: Add missing webgpu includes
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Rollin
Keywords: InRadar
Depends on:
Reported: 2019-07-15 13:31 PDT by Keith Rollin
Modified: 2019-07-15 14:40 PDT (History)
4 users (show)

See Also:

Patch (1.78 KB, patch)
2019-07-15 13:34 PDT, Keith Rollin
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Rollin 2019-07-15 13:31:27 PDT
WHLSLFunctionWriter.cpp fails to compile on tvOS and watchOS due to missing includes. This file likely compiles on other platforms due to the Unified Sources facility that clumps several implementation files together, exposing those implementation files to the others' includes. It fails on tvOS and watchOS due to the different ways these implementation files can get clumped together on different platforms.
Comment 1 Radar WebKit Bug Importer 2019-07-15 13:32:15 PDT
Comment 2 Keith Rollin 2019-07-15 13:34:27 PDT
Created attachment 374142 [details]
Comment 3 WebKit Commit Bot 2019-07-15 14:40:34 PDT
Comment on attachment 374142 [details]

Clearing flags on attachment: 374142

Committed r247450: <https://trac.webkit.org/changeset/247450>
Comment 4 WebKit Commit Bot 2019-07-15 14:40:36 PDT
All reviewed patches have been landed.  Closing bug.