Bug 199800 - [WPE][GTK] Improvements and fixes in FileSystemGlib.cpp
Summary: [WPE][GTK] Improvements and fixes in FileSystemGlib.cpp
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: PC Linux
: P2 Normal
Assignee: Michael Catanzaro
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-07-15 12:37 PDT by Michael Catanzaro
Modified: 2019-07-16 01:09 PDT (History)
9 users (show)

See Also:

Attachments
Patch (5.53 KB, patch)
2019-07-15 13:00 PDT, Michael Catanzaro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2019-07-15 12:37:01 PDT 
* Use nullptr
 * Fix GFileInfo leak in getFileSize
 * Use GRefPtr to clarify ownership of the GFileIOStream in openFile
Comment 1 Michael Catanzaro 2019-07-15 13:00:28 PDT 
Created attachment 374137 [details]
Patch
Comment 2 Carlos Garcia Campos 2019-07-16 00:40:10 PDT 
Comment on attachment 374137 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=374137&action=review

> Source/WTF/wtf/glib/FileSystemGlib.cpp:358
> -    return ioStream;
> +    return ioStream.leakRef();

I don't see why this clarifies anything, but ok.
Comment 3 WebKit Commit Bot 2019-07-16 01:09:58 PDT 
Comment on attachment 374137 [details]
Patch

Clearing flags on attachment: 374137

Committed r247477: <https://trac.webkit.org/changeset/247477>
Comment 4 WebKit Commit Bot 2019-07-16 01:09:59 PDT 
All reviewed patches have been landed.  Closing bug.