Bug 199788 - [macOS 10.15] Cannot unbold selected text when the system font is used
Summary: [macOS 10.15] Cannot unbold selected text when the system font is used
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-07-14 15:20 PDT by Wenson Hsieh
Modified: 2019-07-15 16:10 PDT (History)
7 users (show)

See Also:


Attachments
Patch (16.11 KB, patch)
2019-07-14 17:03 PDT, Wenson Hsieh
no flags Details | Formatted Diff | Diff
Remove unintended logging (15.80 KB, patch)
2019-07-14 17:06 PDT, Wenson Hsieh
no flags Details | Formatted Diff | Diff
Patch (2.45 KB, patch)
2019-07-15 14:54 PDT, Wenson Hsieh
thorton: review+
wenson_hsieh: commit-queue+
Details | Formatted Diff | Diff
Patch (10.10 KB, patch)
2019-07-15 15:45 PDT, Wenson Hsieh
thorton: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2019-07-14 15:20:45 PDT
<rdar://problem/52142570>
Comment 1 Wenson Hsieh 2019-07-14 17:03:48 PDT Comment hidden (obsolete)
Comment 2 Wenson Hsieh 2019-07-14 17:06:35 PDT
Created attachment 374101 [details]
Remove unintended logging
Comment 3 WebKit Commit Bot 2019-07-15 12:09:57 PDT
Comment on attachment 374101 [details]
Remove unintended logging

Clearing flags on attachment: 374101

Committed r247439: <https://trac.webkit.org/changeset/247439>
Comment 4 WebKit Commit Bot 2019-07-15 12:09:59 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Wenson Hsieh 2019-07-15 14:54:23 PDT
Reopening to attach new patch.
Comment 6 Wenson Hsieh 2019-07-15 14:54:24 PDT Comment hidden (obsolete)
Comment 7 Wenson Hsieh 2019-07-15 15:45:17 PDT
Created attachment 374158 [details]
Patch
Comment 8 Tim Horton 2019-07-15 15:47:55 PDT
Comment on attachment 374158 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=374158&action=review

> Source/WebKit/ChangeLog:11
> +        restore the older CallbackID-based async IPC.

oO oO oO
Comment 9 Wenson Hsieh 2019-07-15 15:49:10 PDT
(In reply to Tim Horton from comment #8)
> Comment on attachment 374158 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=374158&action=review
> 
> > Source/WebKit/ChangeLog:11
> > +        restore the older CallbackID-based async IPC.
> 
> oO oO oO

Regretfully so 😢
Comment 10 Wenson Hsieh 2019-07-15 16:10:05 PDT
Comment on attachment 374158 [details]
Patch

Committed r247460: <https://trac.webkit.org/changeset/247460>