Streamline PODIntervalTree code and remove ValueToString
Created attachment 374087 [details] Patch
Comment on attachment 374087 [details] Patch Attachment 374087 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/12738418 New failing tests: fast/multicol/simple-line-layout-widows-when-switching-over-to-normal-line-layout.html fast/multicol/pagination/LeftToRight-tb-hittest.html
Created attachment 374088 [details] Archive of layout-test-results from ews101 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-highsierra Platform: Mac OS X 10.13.6
Comment on attachment 374087 [details] Patch Attachment 374087 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/12738426 New failing tests: fast/multicol/simple-line-layout-widows-when-switching-over-to-normal-line-layout.html fast/multicol/pagination/LeftToRight-tb-hittest.html
Created attachment 374089 [details] Archive of layout-test-results from ews107 for mac-highsierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6
Comment on attachment 374087 [details] Patch Attachment 374087 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/12738475 New failing tests: fast/multicol/simple-line-layout-widows-when-switching-over-to-normal-line-layout.html fast/multicol/pagination/LeftToRight-tb-hittest.html
Created attachment 374091 [details] Archive of layout-test-results from ews117 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews117 Port: mac-highsierra Platform: Mac OS X 10.13.6
Comment on attachment 374087 [details] Patch Attachment 374087 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/12738479 New failing tests: fast/multicol/simple-line-layout-widows-when-switching-over-to-normal-line-layout.html
Created attachment 374092 [details] Archive of layout-test-results from ews121 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews121 Port: ios-simulator-wk2 Platform: Mac OS X 10.14.5
Comment on attachment 374087 [details] Patch Attachment 374087 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/12738529 New failing tests: fast/multicol/simple-line-layout-widows-when-switching-over-to-normal-line-layout.html fast/multicol/pagination/LeftToRight-tb-hittest.html
Created attachment 374093 [details] Archive of layout-test-results from ews215 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews215 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Created attachment 385022 [details] Patch
Created attachment 385099 [details] Patch
Created attachment 385104 [details] Patch
OK, everything seems to be working perfectly now and all the bubbles on EWS are green, so I'd like to find someone to review.
Comment on attachment 385104 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=385104&action=review > Source/WebCore/platform/PODRedBlackTree.h:104 > + insertNode(new Node(T { data })); Would be nice if insertNode took a unique_ptr - seeing "new" in modern C++ code always makes me uneasy.
Comment on attachment 385104 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=385104&action=review >> Source/WebCore/platform/PODRedBlackTree.h:104 >> + insertNode(new Node(T { data })); > > Would be nice if insertNode took a unique_ptr - seeing "new" in modern C++ code always makes me uneasy. I’ll try that out in a follow-up. (As you know, often my challenge is when to *stop* tweaking and refactoring.)
Committed r253290