Bug 199779 - Don't do async overflow scrolling for visibility:hidden scrollers
Summary: Don't do async overflow scrolling for visibility:hidden scrollers
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Scrolling (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-07-13 12:04 PDT by Simon Fraser (smfr)
Modified: 2019-07-13 15:40 PDT (History)
5 users (show)

See Also:


Attachments
Patch (8.02 KB, patch)
2019-07-13 13:46 PDT, Simon Fraser (smfr)
dino: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2019-07-13 12:04:27 PDT
If a scroller has visibility:hidden, don't trigger the async overflow scroll code path.

Some JS libraries make visibility:hidden scrollers (https://github.com/wnr/element-resize-detector) and we need to avoid the compositing cost.

I filed https://github.com/w3c/csswg-drafts/issues/4113 on this not being well-defined in CSS, and expect that to be resolved in a way that prevents scrolling.
Comment 1 Radar WebKit Bug Importer 2019-07-13 12:05:11 PDT
<rdar://problem/53056654>
Comment 2 Simon Fraser (smfr) 2019-07-13 13:46:03 PDT
Created attachment 374081 [details]
Patch
Comment 3 Simon Fraser (smfr) 2019-07-13 15:34:57 PDT
https://trac.webkit.org/changeset/247420/webkit