Bug 199765 - Increase JSValue cage size on iOS and reduce the max slide
Summary: Increase JSValue cage size on iOS and reduce the max slide
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Miller
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-07-12 16:02 PDT by Keith Miller
Modified: 2019-07-12 17:23 PDT (History)
2 users (show)

See Also:

Attachments
Patch (1.76 KB, patch)
2019-07-12 16:09 PDT, Keith Miller 		saam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Miller 2019-07-12 16:02:22 PDT 
Increase JSValue cage size on iOS and reduce the max slide
Comment 1 Keith Miller 2019-07-12 16:09:59 PDT 
Created attachment 374048 [details]
Patch
Comment 2 Keith Miller 2019-07-12 16:11:05 PDT 
rdar://problem/52589569
Comment 3 Saam Barati 2019-07-12 16:21:29 PDT 
Comment on attachment 374048 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=374048&action=review

> Source/bmalloc/bmalloc/Gigacage.h:71
>  constexpr size_t primitiveGigacageSize = 2 * bmalloc::Sizes::GB;
> -constexpr size_t jsValueGigacageSize = 1 * bmalloc::Sizes::GB;
> +constexpr size_t jsValueGigacageSize = 2 * bmalloc::Sizes::GB;

should we bump to 4gb/4gb?
Comment 4 Saam Barati 2019-07-12 16:21:57 PDT 
Comment on attachment 374048 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=374048&action=review

> Source/bmalloc/ChangeLog:12
> +

might be nice for posterity to state that cage size is now 36gb and we ask for a 38gb allocation
Comment 5 Keith Miller 2019-07-12 17:22:32 PDT 
Comment on attachment 374048 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=374048&action=review

>> Source/bmalloc/ChangeLog:12
>> +
> 
> might be nice for posterity to state that cage size is now 36gb and we ask for a 38gb allocation

Done.

>> Source/bmalloc/bmalloc/Gigacage.h:71
>> +constexpr size_t jsValueGigacageSize = 2 * bmalloc::Sizes::GB;
> 
> should we bump to 4gb/4gb?

I'm not sure that's necessary. If we still have a problem we can consider it later.
Comment 6 Keith Miller 2019-07-12 17:23:16 PDT 
Committed r247409: <https://trac.webkit.org/changeset/247409>