Bug 199754 - Regression(macOS Catalina): Cannot quick look html documents in Mail
Summary: Regression(macOS Catalina): Cannot quick look html documents in Mail
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-07-12 13:11 PDT by Chris Dumez
Modified: 2019-09-19 16:10 PDT (History)
8 users (show)

See Also:


Attachments
Patch (2.53 KB, patch)
2019-07-12 13:14 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (2.59 KB, patch)
2019-07-12 14:06 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2019-07-12 13:11:25 PDT
Cannot quick look html documents in Mail due to sandboxing errors.
Comment 1 Chris Dumez 2019-07-12 13:11:41 PDT
<rdar://problem/51304961>
Comment 2 Chris Dumez 2019-07-12 13:14:22 PDT
Created attachment 374029 [details]
Patch
Comment 3 Geoffrey Garen 2019-07-12 13:15:56 PDT
Comment on attachment 374029 [details]
Patch

Can we test this with an API test?
Comment 4 Chris Dumez 2019-07-12 13:20:57 PDT
(In reply to Geoffrey Garen from comment #3)
> Comment on attachment 374029 [details]
> Patch
> 
> Can we test this with an API test?

No, as far as I know, we cannot API test sandboxing since TestWebKitAPI is not sandboxed.
Comment 5 Chris Dumez 2019-07-12 13:51:43 PDT
Comment on attachment 374029 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=374029&action=review

> Source/WebKit/UIProcess/WebPageProxy.cpp:1061
>      // FIXME: universal file read access should be set if the sandbox extension is successfully created: rdar://problem/52357508.

Oh, I should drop this comment too. I am currently validating that my patch did not regress what rdar://problem/52357508 was trying to fix, before I land this.
Comment 6 Chris Dumez 2019-07-12 14:04:35 PDT
Comment on attachment 374029 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=374029&action=review

>> Source/WebKit/UIProcess/WebPageProxy.cpp:1061
>>      // FIXME: universal file read access should be set if the sandbox extension is successfully created: rdar://problem/52357508.
> 
> Oh, I should drop this comment too. I am currently validating that my patch did not regress what rdar://problem/52357508 was trying to fix, before I land this.

Ok, I have confirmed that rdar://problem/52357508 is also fixed with my patch. I'll drop the FIXME comment before landing.
Comment 7 Chris Dumez 2019-07-12 14:06:00 PDT
Created attachment 374034 [details]
Patch
Comment 8 WebKit Commit Bot 2019-07-12 15:03:33 PDT
Comment on attachment 374034 [details]
Patch

Clearing flags on attachment: 374034

Committed r247400: <https://trac.webkit.org/changeset/247400>
Comment 9 WebKit Commit Bot 2019-07-12 15:03:35 PDT
All reviewed patches have been landed.  Closing bug.