Cannot quick look html documents in Mail due to sandboxing errors.
<rdar://problem/51304961>
Created attachment 374029 [details] Patch
Comment on attachment 374029 [details] Patch Can we test this with an API test?
(In reply to Geoffrey Garen from comment #3) > Comment on attachment 374029 [details] > Patch > > Can we test this with an API test? No, as far as I know, we cannot API test sandboxing since TestWebKitAPI is not sandboxed.
Comment on attachment 374029 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=374029&action=review > Source/WebKit/UIProcess/WebPageProxy.cpp:1061 > // FIXME: universal file read access should be set if the sandbox extension is successfully created: rdar://problem/52357508. Oh, I should drop this comment too. I am currently validating that my patch did not regress what rdar://problem/52357508 was trying to fix, before I land this.
Comment on attachment 374029 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=374029&action=review >> Source/WebKit/UIProcess/WebPageProxy.cpp:1061 >> // FIXME: universal file read access should be set if the sandbox extension is successfully created: rdar://problem/52357508. > > Oh, I should drop this comment too. I am currently validating that my patch did not regress what rdar://problem/52357508 was trying to fix, before I land this. Ok, I have confirmed that rdar://problem/52357508 is also fixed with my patch. I'll drop the FIXME comment before landing.
Created attachment 374034 [details] Patch
Comment on attachment 374034 [details] Patch Clearing flags on attachment: 374034 Committed r247400: <https://trac.webkit.org/changeset/247400>
All reviewed patches have been landed. Closing bug.