Bug 199749 - [MSE] Reenqueue after removeCodedFrames()
Summary: [MSE] Reenqueue after removeCodedFrames()
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alicia Boya García
Keywords: InRadar
Depends on:
Reported: 2019-07-12 03:29 PDT by Alicia Boya García
Modified: 2019-07-24 11:14 PDT (History)
4 users (show)

See Also:

Patch (7.60 KB, patch)
2019-07-12 03:31 PDT, Alicia Boya García
no flags Details | Formatted Diff | Diff
Patch (7.60 KB, patch)
2019-07-16 05:19 PDT, Alicia Boya García
no flags Details | Formatted Diff | Diff
Patch (7.61 KB, patch)
2019-07-24 09:55 PDT, Alicia Boya García
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alicia Boya García 2019-07-12 03:29:32 PDT
Before this patch, SourceBuffer::removeCodedFrames() did not trigger
an immediate reenqueue, but rather just set the `needsReenqueuing`
flag, deferring it for the next append... but there may not be another
append! In that case, the removed frames would still wrongly play.

This is the case for instance in tests where a single long media
append is done and then "cropped" with SourceBuffer.erase().

Test: media/media-source/media-source-erase-after-last-append.html
Comment 1 Alicia Boya García 2019-07-12 03:31:18 PDT
Created attachment 374002 [details]
Comment 2 Xabier Rodríguez Calvar 2019-07-15 06:35:04 PDT
Comment on attachment 374002 [details]

I see it ok, so r+. Then we have Apple EWS going very red on this, so maybe you check why and wait for Jer and Eric so say something as well.
Comment 3 Alicia Boya García 2019-07-16 04:40:25 PDT
It's failing because it's missing the AtomicString -> AtomString rename, I'll re-upload with that fixed as soon as I clean up my git finishing changes in the WebKitMediaSrc patch.
Comment 4 Alicia Boya García 2019-07-16 05:19:26 PDT
Created attachment 374205 [details]
Comment 5 WebKit Commit Bot 2019-07-24 09:32:33 PDT
Comment on attachment 374205 [details]

Rejecting attachment 374205 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 374205, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in LayoutTests/ChangeLog contains OOPS!.

Full output: https://webkit-queues.webkit.org/results/12801817
Comment 6 Alicia Boya García 2019-07-24 09:55:02 PDT
Created attachment 374785 [details]
Comment 7 WebKit Commit Bot 2019-07-24 11:13:12 PDT
Comment on attachment 374785 [details]

Clearing flags on attachment: 374785

Committed r247783: <https://trac.webkit.org/changeset/247783>
Comment 8 WebKit Commit Bot 2019-07-24 11:13:13 PDT
All reviewed patches have been landed.  Closing bug.
Comment 9 Radar WebKit Bug Importer 2019-07-24 11:14:22 PDT