WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
199748
[ATK] Avoid unneeded call to to core(selection) in listObjectForSelection()
https://bugs.webkit.org/show_bug.cgi?id=199748
Summary
[ATK] Avoid unneeded call to to core(selection) in listObjectForSelection()
Adrian Perez
Reported
2019-07-12 01:34:45 PDT
In Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceSelection.cpp: The “coreSelection“ returned by “core()” is already null-checked inside “optionFromList()” before calling “listObjectForSelection”, and this is the only call site. While technically there is no issue here, a small refactoring could be done to pass “coreSelection” to it, instead of passing the plain “selection” and needing to call “core(selection)” multiple times.
Attachments
Patch
(2.41 KB, patch)
2019-07-12 01:43 PDT
,
Adrian Perez
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2019-07-12 01:35:02 PDT
<
rdar://problem/52995908
>
Adrian Perez
Comment 2
2019-07-12 01:43:06 PDT
Created
attachment 374001
[details]
Patch
WebKit Commit Bot
Comment 3
2019-07-12 03:09:03 PDT
Comment on
attachment 374001
[details]
Patch Clearing flags on attachment: 374001 Committed
r247384
: <
https://trac.webkit.org/changeset/247384
>
WebKit Commit Bot
Comment 4
2019-07-12 03:09:05 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug