Bug 199739 – Turn off two finger gestures for editable non-scaled content

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Megan Gardner]

Turn off two finger gestures for editable non-scaled content

[Megan Gardner]

Created attachment 373981 [details]
Patch

[Megan Gardner]

Created attachment 373982 [details]
Patch

[Megan Gardner]

<rdar://problem/52107190>

[Tim Horton]

Comment on attachment 373982 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=373982&action=review

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:-763
> -    _twoFingerDoubleTapGestureRecognizer = adoptNS([[UITapGestureRecognizer alloc] initWithTarget:self action:@selector(_twoFingerDoubleTapRecognized:)]);

Why did two finger double tap code move? It's still clearly called (by the line just prior to this), and not disabled anywhere, so this seems pointless? But maybe I'm missing something.

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:806
> +    if (!_webView._editable)

I have a Question! Presumably single-finger-single-tap on links is also disabled in editable contexts... how is that achieved? Can this follow the same path? (maybe not!)

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:3967
> +- (void)_setTwoFingerSingleTapGesturesEnabled:(BOOL)enabled
> +{
> +    [_twoFingerSingleTapGestureRecognizer setEnabled:enabled];
> +}

This seems like a rather unnecessary method.

[Megan Gardner]

Created attachment 374044 [details]
Patch

[Megan Gardner]

Created attachment 374057 [details]
Patch

[Tim Horton]

Comment on attachment 374057 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=374057&action=review

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:793
> +    [_twoFingerSingleTapGestureRecognizer setEnabled:!_webView._editable];

I am sold! Though I would probably put it before the add, with all the other setters.

[Megan Gardner]

Created attachment 374061 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 374061 [details]
Patch for landing

Clearing flags on attachment: 374061

Committed r247411: <https://trac.webkit.org/changeset/247411>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.