...
<rdar://problem/52551332>
Created attachment 373977 [details] Patch
Comment on attachment 373977 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=373977&action=review r=me > Tools/TestWebKitAPI/Tests/WebKitCocoa/opendatabase-always-exists.html:18 > + if (window.openDatabase == func) { ===
Created attachment 374025 [details] Patch for landing
Comment on attachment 374025 [details] Patch for landing View in context: https://bugs.webkit.org/attachment.cgi?id=374025&action=review > Source/WebCore/ChangeLog:13 > + Modified API test: WebSQL.OpenDatabaseAlwaysExists > + > + * Modules/webdatabase/DOMWindowWebDatabase.idl: > + * bindings/js/JSDOMWindowCustom.cpp: > + (WebCore::JSDOMWindow::setOpenDatabase): This really needs an explanation. Please do try to explain what the change is doing and why in the ChangeLog.
Created attachment 374053 [details] Patch for landing
Created attachment 374054 [details] Patch for landing
Comment on attachment 374054 [details] Patch for landing Rejecting attachment 374054 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 374054, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!. Full output: https://webkit-queues.webkit.org/results/12728934
Created attachment 374116 [details] Patch for landing
Comment on attachment 374116 [details] Patch for landing Clearing flags on attachment: 374116 Committed r247434: <https://trac.webkit.org/changeset/247434>
All reviewed patches have been landed. Closing bug.