Bug 199730 - Begin unifying WebKitLegacy sources
Summary: Begin unifying WebKitLegacy sources
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-07-11 15:46 PDT by Alex Christensen
Modified: 2019-07-12 15:09 PDT (History)
3 users (show)

See Also:

Attachments
Patch (27.16 KB, patch)
2019-07-11 15:46 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (28.44 KB, patch)
2019-07-11 17:25 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (29.23 KB, patch)
2019-07-12 10:27 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2019-07-11 15:46:03 PDT 
Begin unifying WebKitLegacy sources
Comment 1 Alex Christensen 2019-07-11 15:46:14 PDT 
Created attachment 373967 [details]
Patch
Comment 2 Alex Christensen 2019-07-11 17:25:07 PDT 
Created attachment 373979 [details]
Patch
Comment 3 Alex Christensen 2019-07-12 10:27:24 PDT 
Created attachment 374019 [details]
Patch
Comment 4 Keith Miller 2019-07-12 14:09:16 PDT 
Comment on attachment 374019 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=374019&action=review

r=me with comment.

> Source/WebKitLegacy/scripts/generate-unified-sources.sh:21
> +    echo "Using unified source list files: Sources.txt, SourcesCocoa.txt"

Is there a way to make this echo use the same values that are passed to the generate-unified-source-bundles.rb call below?
Comment 5 Alex Christensen 2019-07-12 14:16:33 PDT 
Comment on attachment 374019 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=374019&action=review

>> Source/WebKitLegacy/scripts/generate-unified-sources.sh:21
>> +    echo "Using unified source list files: Sources.txt, SourcesCocoa.txt"
> 
> Is there a way to make this echo use the same values that are passed to the generate-unified-source-bundles.rb call below?

If that's important we should make JavaScriptCore and WebCore do the same thing in a different patch.
Comment 6 WebKit Commit Bot 2019-07-12 15:08:09 PDT 
Comment on attachment 374019 [details]
Patch

Clearing flags on attachment: 374019

Committed r247401: <https://trac.webkit.org/changeset/247401>
Comment 7 WebKit Commit Bot 2019-07-12 15:08:10 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2019-07-12 15:09:21 PDT 
<rdar://problem/53029166>