Bug 199729 - API tests using permanent credentials should clear credentials left by previous tests
Summary: API tests using permanent credentials should clear credentials left by previo...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sihui Liu
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-07-11 15:06 PDT by Sihui Liu
Modified: 2019-08-02 14:20 PDT (History)
10 users (show)

See Also:

Attachments
Patch (19.64 KB, patch)
2019-07-19 11:58 PDT, Sihui Liu 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews117 for mac-highsierra (3.43 MB, application/zip)
2019-07-19 15:20 PDT, EWS Watchlist 		no flags Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sihui Liu 2019-07-11 15:06:05 PDT 
... because there might be test credentials left from last run somehow, and without clearing them, the test would timeout.
Comment 1 Sihui Liu 2019-07-19 11:58:56 PDT 
Created attachment 374484 [details]
Patch
Comment 2 EWS Watchlist 2019-07-19 15:20:29 PDT 
Comment on attachment 374484 [details]
Patch

Attachment 374484 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/12775132

New failing tests:
webgl/2.0.0/conformance/context/context-release-upon-reload.html
Comment 3 EWS Watchlist 2019-07-19 15:20:30 PDT 
Created attachment 374506 [details]
Archive of layout-test-results from ews117 for mac-highsierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117  Port: mac-highsierra  Platform: Mac OS X 10.13.6
Comment 4 Sihui Liu 2019-07-19 16:30:10 PDT 
This test failure should be unrelated. My patch only changed SPI for API tests and  API tests that are affected.
Comment 5 Aakash Jain 2019-08-02 13:02:21 PDT 
Another example. It seems like  Patch 375113 left the bot (ews119) in bad state in https://ews-build.webkit.org/#/builders/3/builds/5406 and subsequent API test runs on ews119 kept failing 3 API tests (Challenge.BasicProposedCredential, WKWebsiteDataStore.FetchPersistentCredentials, Challenge.SecIdentity), until the machine just got in a very bad state and had to be rebooted and keychain entries for 127.0.0.1 manually removed.
Comment 6 WebKit Commit Bot 2019-08-02 14:19:57 PDT 
Comment on attachment 374484 [details]
Patch

Clearing flags on attachment: 374484

Committed r248181: <https://trac.webkit.org/changeset/248181>
Comment 7 WebKit Commit Bot 2019-08-02 14:19:59 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2019-08-02 14:20:20 PDT 
<rdar://problem/53879414>