Bug 199722 - [ews-build] Add build step to clean up .git/index.lock file
Summary: [ews-build] Add build step to clean up .git/index.lock file
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-07-11 13:19 PDT by Aakash Jain
Modified: 2019-07-11 16:20 PDT (History)
7 users (show)

See Also:


Attachments
Patch (4.77 KB, patch)
2019-07-11 13:23 PDT, Aakash Jain
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2019-07-11 13:19:31 PDT
Sometimes some bots gets into a state when git operations fail with an error: "fatal: Unable to create 'build/.git/index.lock': File exists." , e.g.: https://ews-build.webkit-uat.org/#/builders/40/builds/177

This usually happens when a git operation is interrupted (e.g.: by buildbot restart while git operation was running). Once that happens bot can't recover themself, and they burn through all the build-requests very quickly. This is pretty bad.

To make EWS robust against such issues, we should add build step to delete .git/index.lock file.
Comment 1 Aakash Jain 2019-07-11 13:23:06 PDT
Created attachment 373945 [details]
Patch
Comment 2 Aakash Jain 2019-07-11 13:23:48 PDT
Sample run: https://ews-build.webkit-uat.org/#/builders/40/builds/193
Comment 3 Build Bot 2019-07-11 13:25:39 PDT Comment hidden (obsolete)
Comment 4 WebKit Commit Bot 2019-07-11 14:12:46 PDT
Comment on attachment 373945 [details]
Patch

Clearing flags on attachment: 373945

Committed r247364: <https://trac.webkit.org/changeset/247364>
Comment 5 WebKit Commit Bot 2019-07-11 14:12:48 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2019-07-11 14:13:15 PDT
<rdar://problem/52971180>
Comment 7 Aakash Jain 2019-07-11 16:20:07 PDT
Small follow-up fix: https://trac.webkit.org/changeset/247372/webkit 
Missed this while creating the patch previously.