Bug 199718 – [Text autosizing] Do not nuke the style on dynamicViewportSizeUpdate

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[alan]

<rdar://problem/51900666>

[alan]

Created attachment 373938 [details]
Patch

[alan]

Created attachment 374495 [details]
Patch

[alan]

Created attachment 374501 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 374501 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=374501&action=review

> Source/WebCore/page/Page.cpp:3014
> +void Page::invalidateTextAutoSizeInAllFrames()

recomputeTextAutoSizingInAllFrames

> Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:3362
> +    const Seconds defaultTextAutoSizingDelayOnViewportChange = 80_ms;
> +    auto textAutoSizingDelayOnViewportChange = defaultTextAutoSizingDelayOnViewportChange;
> +    if (willBeVisuallyNonEmptySoon) {
> +        // Be a bit more agressive on the first display.
> +        const Seconds shortTextAutoSizingDelayOnViewportChange = 20_ms;
> +        textAutoSizingDelayOnViewportChange = shortTextAutoSizingDelayOnViewportChange;
> +    } else if (!isVisaullyNonEmpty) {
> +        // We don't anticipate any paining after the next upcoming layout.
> +        const Seconds longTextAutoSizingDelayOnViewportChange = 100_ms;
> +        textAutoSizingDelayOnViewportChange = longTextAutoSizingDelayOnViewportChange;
> +
> +    }

Maybe wrap in a lambda

[alan]

<rdar://problem/53344961>

[alan]

Created attachment 374547 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 374547 [details]
Patch

Clearing flags on attachment: 374547

Committed r247667: <https://trac.webkit.org/changeset/247667>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.