Bug 199717 - Protect CoreAudioSharedUnit::m_clients for accessing in different threads simultaneously
Summary: Protect CoreAudioSharedUnit::m_clients for accessing in different threads sim...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-07-11 12:19 PDT by youenn fablet
Modified: 2019-07-11 21:22 PDT (History)
4 users (show)

See Also:

Attachments
Patch (3.91 KB, patch)
2019-07-11 12:20 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (4.72 KB, patch)
2019-07-11 19:05 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (3.96 KB, patch)
2019-07-11 19:05 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2019-07-11 12:19:06 PDT 
Protect CoreAudioSharedUnit::m_clients for accessing in different threads simultaneously
Comment 1 youenn fablet 2019-07-11 12:20:46 PDT 
Created attachment 373935 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2019-07-11 12:20:49 PDT 
<rdar://problem/52965233>
Comment 3 Eric Carlson 2019-07-11 16:52:24 PDT 
Comment on attachment 373935 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=373935&action=review

> Source/WebCore/platform/mediastream/mac/CoreAudioCaptureSource.cpp:683
> +    {

not: this indentation looks strange
Comment 4 youenn fablet 2019-07-11 19:05:17 PDT 
Created attachment 373992 [details]
Patch for landing
Comment 5 youenn fablet 2019-07-11 19:05:51 PDT 
Created attachment 373993 [details]
Patch for landing
Comment 6 WebKit Commit Bot 2019-07-11 21:22:42 PDT 
Comment on attachment 373993 [details]
Patch for landing

Clearing flags on attachment: 373993

Committed r247381: <https://trac.webkit.org/changeset/247381>
Comment 7 WebKit Commit Bot 2019-07-11 21:22:44 PDT 
All reviewed patches have been landed.  Closing bug.