Bug 199704 - Pages using Google Tag Manager Google's anti-flicker optimization may take ~5 seconds to do initial paint
Summary: Pages using Google Tag Manager Google's anti-flicker optimization may take ~5...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks: 199173
  Show dependency treegraph
 
Reported: 2019-07-11 02:06 PDT by Anthony Ricaud
Modified: 2019-07-11 14:25 PDT (History)
7 users (show)

See Also:


Attachments
Patch (2.59 KB, patch)
2019-07-11 13:17 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anthony Ricaud 2019-07-11 02:06:28 PDT
This is a followup of bug 199173.

Visible on https://www.formula1.com/en.html

This page uses the other snippet to load Google Analytics. I think this is now the main snippet given by Google.


<!-- Page hiding snippet (recommended)  -->
<style>.async-hide { opacity: 0 !important} </style>
<script>(function(a,s,y,n,c,h,i,d,e)
{s.className+=' '+y;h.start=1*new Date; h.end=i=function()
{s.className=s.className.replace(RegExp(' ?'+y),'')};
(a[n]=a[n]||[]).hide=h;setTimeout(function(){i();h.end=null},c);h.timeout=c;
})(window,document.documentElement,'async-hide','dataLayer',4000,
{'GTM-KB77S58':true});
</script>
<!-- Google Tag Manager -->
<script>
    (function(w,d,s,l,i){w[l]=w[l]||[];w[l].push({'gtm.start':
    new Date().getTime(),event:'gtm.js'});var f=d.getElementsByTagName(s)[0],
    j=d.createElement(s),dl=l!='dataLayer'?'&l='+l:'';j.async=true;j.src='https://www.googletagmanager.com/gtm.js?id='+i+dl;f.parentNode.insertBefore(j,f);
})(window,document,'script','dataLayer','GTM-NTR4PPW');
</script>
<!-- End Google Tag Manager -->
Comment 1 Radar WebKit Bug Importer 2019-07-11 12:47:50 PDT
<rdar://problem/52966461>
Comment 2 Chris Dumez 2019-07-11 13:17:13 PDT
Created attachment 373943 [details]
Patch
Comment 3 Geoffrey Garen 2019-07-11 13:38:36 PDT
Comment on attachment 373943 [details]
Patch

r=me
Comment 4 Chris Dumez 2019-07-11 13:52:15 PDT
Comment on attachment 373943 [details]
Patch

Clearing flags on attachment: 373943

Committed r247361: <https://trac.webkit.org/changeset/247361>
Comment 5 Chris Dumez 2019-07-11 13:52:17 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Anthony Ricaud 2019-07-11 14:22:23 PDT
Thank you very much for the quick turnaround!
Comment 7 Chris Dumez 2019-07-11 14:25:52 PDT
(In reply to Anthony Ricaud from comment #6)
> Thank you very much for the quick turnaround!

No problem, thanks for letting us know of this other case.