RESOLVED CONFIGURATION CHANGED 199703
[iOS] WebFrame _handleKeyEvent needs to take WebThreadLock
https://bugs.webkit.org/show_bug.cgi?id=199703
Summary [iOS] WebFrame _handleKeyEvent needs to take WebThreadLock
Ryosuke Niwa
Reported 2019-07-11 00:56:05 PDT
UIKeyboard can call into _handleKeyEvent directly from the main thread.
Attachments
Fixes the bug (1.17 KB, patch)
2019-07-11 00:59 PDT, Ryosuke Niwa
no flags
Radar WebKit Bug Importer
Comment 1 2019-07-11 00:58:56 PDT
Ryosuke Niwa
Comment 2 2019-07-11 00:59:30 PDT
Created attachment 373908 [details] Fixes the bug
Joseph Pecoraro
Comment 3 2019-07-11 13:33:54 PDT
Comment on attachment 373908 [details] Fixes the bug View in context: https://bugs.webkit.org/attachment.cgi?id=373908&action=review > Source/WebKitLegacy/mac/ChangeLog:8 > + Take the web thread lock in this function since it can be directly invoked from UIKit in the main thread. Can UIKit take the lock before calling this? I think that would be better than here in WebKitLegacy.
Ryosuke Niwa
Comment 4 2019-07-11 17:36:58 PDT
Comment on attachment 373908 [details] Fixes the bug Ok
Note You need to log in before you can comment on or make changes to this bug.