Bug 199703 - [iOS] WebFrame _handleKeyEvent needs to take WebThreadLock
Summary: [iOS] WebFrame _handleKeyEvent needs to take WebThreadLock
Status: RESOLVED CONFIGURATION CHANGED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-07-11 00:56 PDT by Ryosuke Niwa
Modified: 2019-07-11 17:37 PDT (History)
5 users (show)

See Also:

Attachments
Fixes the bug (1.17 KB, patch)
2019-07-11 00:59 PDT, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2019-07-11 00:56:05 PDT 
UIKeyboard can call into _handleKeyEvent directly from the main thread.
Comment 1 Radar WebKit Bug Importer 2019-07-11 00:58:56 PDT 
<rdar://problem/52937390>
Comment 2 Ryosuke Niwa 2019-07-11 00:59:30 PDT 
Created attachment 373908 [details]
Fixes the bug
Comment 3 Joseph Pecoraro 2019-07-11 13:33:54 PDT 
Comment on attachment 373908 [details]
Fixes the bug

View in context: https://bugs.webkit.org/attachment.cgi?id=373908&action=review

> Source/WebKitLegacy/mac/ChangeLog:8
> +        Take the web thread lock in this function since it can be directly invoked from UIKit in the main thread.

Can UIKit take the lock before calling this? I think that would be better than here in WebKitLegacy.
Comment 4 Ryosuke Niwa 2019-07-11 17:36:58 PDT 
Comment on attachment 373908 [details]
Fixes the bug

Ok