Bug 199701 - MobileSafari may crash under -[UIKeyboardTaskExecutionContext transferExecutionToMainThreadWithTask:]
Summary: MobileSafari may crash under -[UIKeyboardTaskExecutionContext transferExecuti...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-07-10 20:46 PDT by Wenson Hsieh
Modified: 2019-07-11 00:34 PDT (History)
6 users (show)

See Also:


Attachments
Test (287 bytes, text/html)
2019-07-10 21:02 PDT, Wenson Hsieh
no flags Details
Patch (3.00 KB, patch)
2019-07-10 21:03 PDT, Wenson Hsieh
no flags Details | Formatted Diff | Diff
Patch for landing (4.74 KB, patch)
2019-07-10 22:15 PDT, Wenson Hsieh
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2019-07-10 20:46:23 PDT
<rdar://problem/52590170>
Comment 1 Wenson Hsieh 2019-07-10 21:02:09 PDT
Created attachment 373903 [details]
Test
Comment 2 Wenson Hsieh 2019-07-10 21:03:16 PDT
Created attachment 373904 [details]
Patch
Comment 3 Tim Horton 2019-07-10 21:44:23 PDT
Maybe we want a helper “dispatch failed to fetch autocorrection context if needed” (not a good name but you get the idea). to make the sending empty data more semantically clear at callers, since there are now at least three
Comment 4 Wenson Hsieh 2019-07-10 22:03:05 PDT
(In reply to Tim Horton from comment #3)
> Maybe we want a helper “dispatch failed to fetch autocorrection context if
> needed” (not a good name but you get the idea). to make the sending empty
> data more semantically clear at callers, since there are now at least three

Makes sense! I’ll add a _cancelPendingAutocorrectionContextHandler, and adopt it in the few places that call the completion handler with empty info.
Comment 5 Wenson Hsieh 2019-07-10 22:15:54 PDT
Created attachment 373906 [details]
Patch for landing
Comment 6 WebKit Commit Bot 2019-07-11 00:34:25 PDT
Comment on attachment 373906 [details]
Patch for landing

Clearing flags on attachment: 373906

Committed r247345: <https://trac.webkit.org/changeset/247345>
Comment 7 WebKit Commit Bot 2019-07-11 00:34:26 PDT
All reviewed patches have been landed.  Closing bug.