Bug 19970 - PluginView/Win32 does not compile with MinGW
Summary: PluginView/Win32 does not compile with MinGW
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Plug-ins (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-07-10 03:50 PDT by Ariya Hidayat
Modified: 2008-07-14 02:27 PDT (History)
0 users

See Also:

Attachments
patch to fix the problem (as discussed with aroben and andersca) (2.67 KB, patch)
2008-07-10 04:02 PDT, Ariya Hidayat 		aroben: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ariya Hidayat 2008-07-10 03:50:53 PDT 
The following line causes problem:
friend static LRESULT CALLBACK PluginViewWndProc(HWND, UINT, WPARAM, LPARAM);

since gcc 3.4.5 (on latest stable MinGW) chokes on that.
Comment 1 Ariya Hidayat 2008-07-10 04:02:32 PDT 
Created attachment 22198 [details]
patch to fix the problem (as discussed with aroben and andersca)
Comment 2 Adam Roben (:aroben) 2008-07-10 08:04:43 PDT 
Comment on attachment 22198 [details]
patch to fix the problem (as discussed with aroben and andersca)

r=me
Comment 3 Ariya Hidayat 2008-07-14 02:27:29 PDT 
Landed in r35124