Bug 199698 - Drop non thread-safe usage of WeakPtr in PlaybackSessionInterfaceAVKit
Summary: Drop non thread-safe usage of WeakPtr in PlaybackSessionInterfaceAVKit
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks: 199639
  Show dependency treegraph
 
Reported: 2019-07-10 19:34 PDT by Chris Dumez
Modified: 2019-07-12 19:48 PDT (History)
6 users (show)

See Also:


Attachments
Patch (3.03 KB, patch)
2019-07-10 19:38 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (7.20 KB, patch)
2019-07-11 12:44 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2019-07-10 19:34:12 PDT
Drop non thread-safe usage of WeakPtr in PlaybackSessionInterfaceAVKit.
Comment 1 Chris Dumez 2019-07-10 19:38:01 PDT
Created attachment 373898 [details]
Patch
Comment 2 Brent Fulgham 2019-07-10 22:10:26 PDT
Comment on attachment 373898 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=373898&action=review

Iā€™m not comfortable with this change unless we add some release asserts to prevent this member from being in an invalid state. I can talk to you in person next week if you want background on why this is important.

> Source/WebCore/ChangeLog:14
> +        purposes (Not trying to address a particular crash).

I think your patch should include release-asserts that the pointer is in a safe state when assigned, when being destroyed, etc.
Comment 3 Chris Dumez 2019-07-11 12:44:12 PDT
Created attachment 373939 [details]
Patch
Comment 4 WebKit Commit Bot 2019-07-11 19:35:14 PDT
Comment on attachment 373939 [details]
Patch

Clearing flags on attachment: 373939

Committed r247380: <https://trac.webkit.org/changeset/247380>
Comment 5 WebKit Commit Bot 2019-07-11 19:35:16 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2019-07-11 19:36:43 PDT
<rdar://problem/52985961>