Drop non thread-safe usage of WeakPtr in PlaybackSessionInterfaceAVKit.
Created attachment 373898 [details]
Comment on attachment 373898 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=373898&action=review
I’m not comfortable with this change unless we add some release asserts to prevent this member from being in an invalid state. I can talk to you in person next week if you want background on why this is important.
> + purposes (Not trying to address a particular crash).
I think your patch should include release-asserts that the pointer is in a safe state when assigned, when being destroyed, etc.
Created attachment 373939 [details]
Comment on attachment 373939 [details]
Clearing flags on attachment: 373939
Committed r247380: <https://trac.webkit.org/changeset/247380>
All reviewed patches have been landed. Closing bug.