Bug 199695 - [WHLSL] Optional<UniqueRef<T>> -> std::unique_ptr in Return/IfStatement/ForLoop
Summary: [WHLSL] Optional<UniqueRef<T>> -> std::unique_ptr in Return/IfStatement/ForLoop
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGPU (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Robin Morisset
URL:
Keywords: InRadar
Depends on: 199389
Blocks:
  Show dependency tree / graph
 
Reported: 2019-07-10 18:17 PDT by Robin Morisset
Modified: 2019-07-10 19:10 PDT (History)
3 users (show)

See Also:

Attachments
Patch (7.18 KB, patch)
2019-07-10 18:21 PDT, Robin Morisset 		no flags Details | Formatted Diff | Diff
Patch (8.30 KB, patch)
2019-07-10 18:22 PDT, Robin Morisset 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Robin Morisset 2019-07-10 18:17:39 PDT 
Same reasoning as https://bugs.webkit.org/show_bug.cgi?id=199389
Saves 8 bytes per If/Return, 16 bytes per For, and the patch is trivial.
Comment 1 Robin Morisset 2019-07-10 18:21:05 PDT 
Created attachment 373886 [details]
Patch
Comment 2 Robin Morisset 2019-07-10 18:22:56 PDT 
Created attachment 373887 [details]
Patch
Comment 3 WebKit Commit Bot 2019-07-10 19:09:58 PDT 
Comment on attachment 373887 [details]
Patch

Clearing flags on attachment: 373887

Committed r247341: <https://trac.webkit.org/changeset/247341>
Comment 4 WebKit Commit Bot 2019-07-10 19:09:59 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2019-07-10 19:10:26 PDT 
<rdar://problem/52927323>