Bug 199693 - [iOS WK2] With modal overlay and body overflow:hidden, can't access all the content
Summary: [iOS WK2] With modal overlay and body overflow:hidden, can't access all the c...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-07-10 17:46 PDT by Simon Fraser (smfr)
Modified: 2019-07-10 21:28 PDT (History)
12 users (show)

See Also:


Attachments
Patch (41.26 KB, patch)
2019-07-10 17:51 PDT, Simon Fraser (smfr)
thorton: review+
ews: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews105 for mac-highsierra-wk2 (2.74 MB, application/zip)
2019-07-10 19:13 PDT, Build Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2019-07-10 17:46:08 PDT
[iOS WK2] With modal overlay and body overflow:hidden, can't access all the content
Comment 1 Simon Fraser (smfr) 2019-07-10 17:51:49 PDT
Created attachment 373882 [details]
Patch
Comment 2 Simon Fraser (smfr) 2019-07-10 17:51:51 PDT
<rdar://problem/51930364>
Comment 3 Build Bot 2019-07-10 17:53:29 PDT
Attachment 373882 [details] did not pass style-queue:


ERROR: Source/WebCore/page/scrolling/ScrollingTreeFrameScrollingNode.h:47:  Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line.  [build/webcore_export] [4]
ERROR: Source/WebKit/ChangeLog:10:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
ERROR: Source/WebKit/ChangeLog:11:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
ERROR: Source/WebKit/ChangeLog:12:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
ERROR: Source/WebCore/ChangeLog:10:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
ERROR: Source/WebCore/ChangeLog:11:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
ERROR: Source/WebCore/ChangeLog:12:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
Total errors found: 7 in 19 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Tim Horton 2019-07-10 18:18:24 PDT
Comment on attachment 373882 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=373882&action=review

> Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:2029
> +    bool scrollingNeededToRevealUI = false;

I don't know that this is the best name (nor do I love the changelog wording). Could be more abstractly worded.

> Tools/TestWebKitAPI/Tests/ios/ScrollViewScrollabilityTests.mm:2
> + * Copyright (C) 2018 Apple Inc. All rights reserved.

alas, it is not 2018. it's barely even 2019 anymore
Comment 5 Build Bot 2019-07-10 19:13:22 PDT
Comment on attachment 373882 [details]
Patch

Attachment 373882 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/12711820

New failing tests:
fast/visual-viewport/tiled-drawing/zoomed-fixed-scrolling-layers-state.html
fast/visual-viewport/tiled-drawing/zoomed-fixed-scrolled-down-then-up.html
fast/visual-viewport/tiled-drawing/zoomed-fixed-scrolled-down.html
Comment 6 Build Bot 2019-07-10 19:13:23 PDT
Created attachment 373895 [details]
Archive of layout-test-results from ews105 for mac-highsierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-highsierra-wk2  Platform: Mac OS X 10.13.6
Comment 7 Simon Fraser (smfr) 2019-07-10 21:28:31 PDT
https://trac.webkit.org/changeset/247344/webkit