Bug 199692 - AX: Implement support for ARIA roles insertion, deletion, subscript, superscript, and time
Summary: AX: Implement support for ARIA roles insertion, deletion, subscript, superscr...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joanmarie Diggs (irc: joanie)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-07-10 16:57 PDT by Joanmarie Diggs (irc: joanie)
Modified: 2019-07-11 06:36 PDT (History)
13 users (show)

See Also:


Attachments
Patch (48.84 KB, patch)
2019-07-10 18:08 PDT, Joanmarie Diggs (irc: joanie)
no flags Details | Formatted Diff | Diff
Patch (50.56 KB, patch)
2019-07-10 18:32 PDT, Joanmarie Diggs (irc: joanie)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joanmarie Diggs (irc: joanie) 2019-07-10 16:57:32 PDT
ARIA 1.2 continues to add roles for role parity with HTML. The next batch are insertion, deletion, subscript, superscript, and time.

We should also take this opportunity to update the ATK mappings for the ins and del elements. There are new AtkRole types: ATK_ROLE_CONTENT_INSERTION and ATK_ROLE_CONTENT_DELETION.

(Assigning to myself. Patch will be forthcoming.)
Comment 1 Radar WebKit Bug Importer 2019-07-10 16:57:48 PDT
<rdar://problem/52921786>
Comment 2 Joanmarie Diggs (irc: joanie) 2019-07-10 18:08:13 PDT
Created attachment 373884 [details]
Patch
Comment 3 Joanmarie Diggs (irc: joanie) 2019-07-10 18:21:41 PDT
Comment on attachment 373884 [details]
Patch

Clearing the review flag. Looks like I forgot the iOS changes....
Comment 4 Joanmarie Diggs (irc: joanie) 2019-07-10 18:32:09 PDT
Created attachment 373888 [details]
Patch
Comment 5 Joanmarie Diggs (irc: joanie) 2019-07-10 19:53:53 PDT
Chris: Please review. Thanks in advance!
Comment 6 chris fleizach 2019-07-10 23:37:43 PDT
Comment on attachment 373888 [details]
Patch

looks good
Comment 7 WebKit Commit Bot 2019-07-11 06:36:56 PDT
Comment on attachment 373888 [details]
Patch

Clearing flags on attachment: 373888

Committed r247349: <https://trac.webkit.org/changeset/247349>
Comment 8 WebKit Commit Bot 2019-07-11 06:36:58 PDT
All reviewed patches have been landed.  Closing bug.