Bug 199688 – [WHLSL] The recursion checker should not have quadratic complexity

• Status: RESOLVED
• Resolution: FIXED
• Component: WebGPU

[Robin Morisset]

...

[Robin Morisset]

Created attachment 373878 [details]
Patch

[Saam Barati]

Comment on attachment 373878 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=373878&action=review

> Source/WebCore/Modules/webgpu/WHLSL/WHLSLRecursionChecker.cpp:47
> +    void visit(Program& program) override
> +    {
> +        for (auto& functionDefinition : program.functionDefinitions())
> +            checkErrorAndVisit(functionDefinition);
> +    }

Nice. We should probably do this in more phases.

> Source/WebCore/Modules/webgpu/WHLSL/WHLSLRecursionChecker.cpp:62
> +        auto addResult2 = m_finishedVisiting.add(&functionDefinition);
> +        ASSERT_UNUSED(addResult2, addResult2);

this probably doesn't compile on debug builds. You want addResult2.isNewEntry.

Also, can you just give it its own scope instead of calling it addResult2? Or perhaps limit scope to above addResult?

[Robin Morisset]

Created attachment 373880 [details]
Patch

[Robin Morisset]

Created attachment 373881 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 373881 [details]
Patch

Clearing flags on attachment: 373881

Committed r247339: <https://trac.webkit.org/changeset/247339>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/52925463>