Bug 199676 - [WebGPU] Implement GPUUncapturedErrorEvent
Summary: [WebGPU] Implement GPUUncapturedErrorEvent
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGPU (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P3 Normal
Assignee: Justin Fan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-07-10 11:26 PDT by Justin Fan
Modified: 2022-02-10 16:40 PST (History)
5 users (show)

See Also:


Attachments
Patch (41.57 KB, patch)
2019-09-04 18:13 PDT, Justin Fan
no flags Details | Formatted Diff | Diff
Patch (46.11 KB, patch)
2019-09-05 16:26 PDT, Justin Fan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Justin Fan 2019-07-10 11:26:55 PDT
Errors not captured by any error scope should be fired as Events on the GPUDevice and reported to console.
Comment 1 Justin Fan 2019-09-04 18:13:41 PDT
Created attachment 378032 [details]
Patch
Comment 2 WebKit Commit Bot 2019-09-05 12:22:05 PDT
Comment on attachment 378032 [details]
Patch

Clearing flags on attachment: 378032

Committed r249539: <https://trac.webkit.org/changeset/249539>
Comment 3 WebKit Commit Bot 2019-09-05 12:22:07 PDT
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2019-09-05 12:23:16 PDT
<rdar://problem/55078734>
Comment 5 Ryan Haddad 2019-09-05 15:47:28 PDT
There are quite a few webgpu layout test failures on Mojave bots after this change: https://build.webkit.org/results/Apple%20Mojave%20Release%20WK2%20(Tests)/r249539%20(6413)/results.html
Comment 6 Justin Fan 2019-09-05 16:26:02 PDT
Reopening to attach new patch.
Comment 7 Justin Fan 2019-09-05 16:26:03 PDT
Created attachment 378135 [details]
Patch
Comment 8 Justin Fan 2019-09-06 14:54:41 PDT
Fixes added in https://trac.webkit.org/changeset/249555/webkit